You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/11 10:27:03 UTC
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #470: Proposal: Health Checks for Upstream
juzhiyuan opened a new issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470
## Why
Doc: https://github.com/apache/apisix/blob/master/doc/health-check.md
## How
Active and passive checks exist in parallel in the upstream module as separate configurations, they should obey the following rules.
1. All disabled: Only show the Ant Design Switcher components for those two fields, no more configuration form；
2. Enable active check: show its configuration form；
3. Enable passive check
1. Check if the active check is enabled, if not, just show a warning notification by using Ant Design’s Notification component, and tell users to enable the active check first.
2. If the active check is enabled, then users could enable the passive check and show its form.
## API
1. Test cases: https://github.com/apache/apisix/blob/master/t/admin/health-check.t#L61
## Reference
1. Default values: TODO
2. Logic: https://github.com/apache/apisix/blob/master/apisix/admin/upstreams.lua
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-692505266
hi @liuxiran, would you like to implement this feature (if you have free time)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691341782
Good catch, @membphis, could you please describe this logic?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431
How about this design?
ping @membphis @liuxiran
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691772846
It's not a hurry :D because we could use Active Health Check and Passive Health Check independent, but we recommend enabling active health check when enabling passive health check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691363046
Even though we could use Passive Check only, but because once the upstream is down, the Gateway doesn't know when to recover just like Active Check does.
So we choose to use Passive check only when the Active check is enabled :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691363046
Even though we could use Passive Check only, but because once the upstream is down, the Gateway doesn't know when to recover just like Active Check does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695333690
`active.type` is mentioned in the test case [=== TEST 6: invalid route: wrong active.type](https://github.com/apache/apisix/blob/8493a607ce869ab335eac1d0e799ffecff10fb93/t/admin/health-check.t#L239), but no details in the api doc, so there is nothing about it in pr. If this key is needed, it would be better to update doc first :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695872120
@liuxiran I just had a quick discussion with @membphis, he will help you to make sure if the `type` filed is needed :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695872120
@liuxiran I just had a quick discussion with @membphis, he will help you to make sure if the `type` filed is needed :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691770513
> Even though we could use Passive Check only, but because once the upstream is down, the Gateway doesn't know when to recover just like Active Check does.
>
> So we choose to use Passive check only when the Active check is enabled :D
so, is it necessary to update the [documentation](https://github.com/apache/apisix/blob/master/doc/health-check.md), add this description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828
> How about this design?
Agree with ui design 👍 , I have a question about interaction logic：
refer to the [upstream health-check doc:](https://github.com/apache/apisix/blob/master/doc/health-check.md) active check and passive check could be configured independently
and you also say：
> Active and passive checks exist in parallel in the upstream module as separate configurations
why does `Enable passive check` depend on whether the active check is enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-692600340
> hi @liuxiran, would you like to implement this feature (if you have free time)?
yes, waiting for my pr :)(later this week)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695364533
> `active.type` is mentioned in the test case [=== TEST 6: invalid route: wrong active.type](https://github.com/apache/apisix/blob/8493a607ce869ab335eac1d0e799ffecff10fb93/t/admin/health-check.t#L239), but no details in the api doc, so there is nothing about it in pr. If this key is needed, it would be better to update doc first :)
hi @moonming @nic-chen @membphis Could you take a look at this test case? I cound't find the `active.type` property either :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695875548
> @liuxiran I just had a quick discussion with @membphis, he will help you to make sure if the `type` filed is needed :D
ok, thanks :), waiting for @membphis `s conclusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691042697
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828
> How about this design?
Agree with ui design 👍 , I have a question about interaction logic：
refer to the [upstream health-check doc:](https://github.com/apache/apisix/blob/master/doc/health-check.md) active check and passive check could be configured independently
and you also say：
> Active and passive checks exist in parallel in the upstream module as separate configurations
why does `Enable passive check` depend on the active check is enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-695875548
> @liuxiran I just had a quick discussion with @membphis, he will help you to make sure if the `type` filed is needed :D
ok, thanks :), waiting for @membphis `s conclusion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691016431
ping @membphis @liuxiran
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828
> How about this design?
Agree with ui design 👍 , I have a question about interaction logic：
refer to the [upstream health-check doc:](https://github.com/apache/apisix/blob/master/doc/health-check.md) active check and passive check could be configured independently
and you also say：
> Active and passive checks exist in parallel in the upstream module as separate configurations
why does `Enable passive check` depend on whether the active check is enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #470: Proposal: Health Checks for Upstream
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #470:
URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-691187828
> How about this design?
Agree with ui design 👍 , I have a question about interaction logic：
refer to the [upstream health-check doc:](https://github.com/apache/apisix/blob/master/doc/health-check.md) active check and passive check could be configured independently
and you also say：
> Active and passive checks exist in parallel in the upstream module as separate configurations
why does `Enable passive check` depend on whether the active check is enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org