You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/06/28 16:17:03 UTC

[GitHub] merlimat commented on a change in pull request #2042: Tests Python Wheel packaging in CI build

merlimat commented on a change in pull request #2042: Tests Python Wheel packaging in CI build
URL: https://github.com/apache/incubator-pulsar/pull/2042#discussion_r198901904
 
 

 ##########
 File path: pulsar-client-cpp/run-unit-tests.sh
 ##########
 @@ -68,11 +68,31 @@ else
     RES=$?
 fi
 
+popd
+
+RES=0
 
 Review comment:
   Good catch! I added that line since I was trying locally with the C++ tests commented out

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services