You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by hl...@apache.org on 2005/10/29 17:07:34 UTC
svn commit: r329422 - in /jakarta/tapestry/trunk:
framework/src/java/org/apache/tapestry/form/FormSupportImpl.java
framework/src/test/org/apache/tapestry/form/FormSupportTest.java status.xml
Author: hlship
Date: Sat Oct 29 08:07:28 2005
New Revision: 329422
URL: http://svn.apache.org/viewcvs?rev=329422&view=rev
Log:
TAPESTRY-699: <div> tag around form hidden fields should not be visible
Modified:
jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java
jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/FormSupportTest.java
jakarta/tapestry/trunk/status.xml
Modified: jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java?rev=329422&r1=329421&r2=329422&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java (original)
+++ jakarta/tapestry/trunk/framework/src/java/org/apache/tapestry/form/FormSupportImpl.java Sat Oct 29 08:07:28 2005
@@ -621,6 +621,7 @@
protected void writeHiddenFields()
{
_writer.begin("div");
+ _writer.attribute("style", "display:none;");
writeHiddenFieldList();
Modified: jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/FormSupportTest.java
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/FormSupportTest.java?rev=329422&r1=329421&r2=329422&view=diff
==============================================================================
--- jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/FormSupportTest.java (original)
+++ jakarta/tapestry/trunk/framework/src/test/org/apache/tapestry/form/FormSupportTest.java Sat Oct 29 08:07:28 2005
@@ -150,7 +150,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "barney,wilma,barney_0");
trainHidden(writer, "service", "fred");
@@ -176,6 +176,12 @@
verifyControls();
}
+ private void trainDiv(IMarkupWriter writer)
+ {
+ writer.begin("div");
+ writer.attribute("style", "display:none;");
+ }
+
protected void trainIsRewound(IRequestCycle cycle, IForm form, boolean isRewound)
{
cycle.isRewound(form);
@@ -311,7 +317,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "");
trainHidden(writer, "service", "fred");
@@ -400,7 +406,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "");
trainHidden(writer, "service", "fred");
@@ -478,7 +484,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "");
trainHidden(writer, "service", "fred");
@@ -617,7 +623,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "action_0");
trainHidden(writer, "action", "fred");
@@ -696,7 +702,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "");
trainHidden(writer, "service", "fred");
@@ -982,7 +988,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "barney");
trainHidden(writer, "service", "fred");
@@ -1061,7 +1067,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "barney");
trainHidden(writer, "service", "fred");
@@ -1154,7 +1160,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "");
trainHidden(writer, "service", "fred");
@@ -1400,7 +1406,7 @@
writer.println();
- writer.begin("div");
+ trainDiv(writer);
trainHidden(writer, "formids", "");
trainHidden(writer, "service", "fred");
Modified: jakarta/tapestry/trunk/status.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/trunk/status.xml?rev=329422&r1=329421&r2=329422&view=diff
==============================================================================
--- jakarta/tapestry/trunk/status.xml (original)
+++ jakarta/tapestry/trunk/status.xml Sat Oct 29 08:07:28 2005
@@ -56,6 +56,7 @@
<action type="update" dev="HLS">Deprecate the Action component and ActionService</action>
<action type="update" dev="HLS">Change the examples distribution to be a pre-configured JBoss distribution</action>
<action type="update" dev="HLS">Deprecate IMonitor and IMonitorFactory (for removal in 4.1)</action>
+ <action type="fix" dev="HLS" fixes-bug="TAPESTRY-699"><div> tag around form hidden fields should not be visible</action>
</release>
<release version="4.0-beta-11" date="Oct 16 2005">
<action type="fix" dev="HLS" fixes-bug="TAPESTRY-650">ClassNotFoundException thrown when deserializing an object from a client persistent property</action>
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org