You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ss...@apache.org on 2016/06/21 15:56:05 UTC

svn commit: r1749562 - /sling/trunk/contrib/extensions/sling-pipes/src/main/java/org/apache/sling/pipes/FilterPipe.java

Author: sseifert
Date: Tue Jun 21 15:56:05 2016
New Revision: 1749562

URL: http://svn.apache.org/viewvc?rev=1749562&view=rev
Log:
SLING-5728 enhance filterpipe logging (patch provided by Nicolas Peltier)

Modified:
    sling/trunk/contrib/extensions/sling-pipes/src/main/java/org/apache/sling/pipes/FilterPipe.java

Modified: sling/trunk/contrib/extensions/sling-pipes/src/main/java/org/apache/sling/pipes/FilterPipe.java
URL: http://svn.apache.org/viewvc/sling/trunk/contrib/extensions/sling-pipes/src/main/java/org/apache/sling/pipes/FilterPipe.java?rev=1749562&r1=1749561&r2=1749562&view=diff
==============================================================================
--- sling/trunk/contrib/extensions/sling-pipes/src/main/java/org/apache/sling/pipes/FilterPipe.java (original)
+++ sling/trunk/contrib/extensions/sling-pipes/src/main/java/org/apache/sling/pipes/FilterPipe.java Tue Jun 21 15:56:05 2016
@@ -44,9 +44,12 @@ public class FilterPipe extends BasePipe
 
     boolean propertiesPass(ValueMap current, ValueMap filter){
         if (filter.containsKey(PN_TEST)){
-            if (!(Boolean) bindings.instantiateObject(filter.get(PN_TEST, "${false}"))){
+            Object test = bindings.instantiateObject(filter.get(PN_TEST, "${false}"));
+            if (! (test instanceof Boolean)){
+                logger.error("instatiated test {} is not a boolean, filtering out", test);
                 return false;
             }
+            return (Boolean) test;
         }
         for (String key : filter.keySet()){
             if (! IGNORED_PROPERTIES.contains(key) && !key.startsWith(PREFIX_FILTER)){
@@ -101,7 +104,7 @@ public class FilterPipe extends BasePipe
                 logger.debug("filter passes for {}", resource.getPath());
                 return super.getOutput();
             } else {
-                logger.info("{} got filtered out", resource.getPath());
+                logger.debug("{} got filtered out", resource.getPath());
             }
         }
         return Collections.emptyIterator();