[GitHub] [spark] yabola commented on a diff in pull request #39950: [SPARK-42388][SQL] Avoid unnecessary parquet footer reads when no filters in vectorized reader

["yabola (via GitHub)" <gi...@apache.org>]

yabola commented on code in PR #39950:
URL: https://github.com/apache/spark/pull/39950#discussion_r1101155361


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala:
##########
@@ -207,11 +207,11 @@ class ParquetFileFormat
 
       lazy val footerFileMetaData =
         ParquetFooterReader.readFooter(sharedConf, filePath, SKIP_ROW_GROUPS).getFileMetaData
-      val datetimeRebaseSpec = DataSourceUtils.datetimeRebaseSpec(
+      lazy val datetimeRebaseSpec = DataSourceUtils.datetimeRebaseSpec(
         footerFileMetaData.getKeyValueMetaData.get,

Review Comment:
   `footerFileMetaData` is lazy, but this method causes the footer to be read immediately. 
   Actually we can avoid this unnecessary footer reads and use footer metadata in `VectorizedParquetRecordReader`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org