You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by arunmahadevan <gi...@git.apache.org> on 2016/12/09 09:42:37 UTC
[GitHub] storm pull request #1820: [STORM-2238] Add Timestamp extractor for windowed ...
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1820
[STORM-2238] Add Timestamp extractor for windowed bolt
Added a timestamp extractor so that the tuple timestamp can be derived from the tuple than directly
mapping it to a field within the tuple.
https://github.com/apache/storm/pull/1819 applied to 1.x-branch
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm STORM-2238-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1820.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1820
----
commit 6f216f7cbcdf840fa050f1a216bcaaf1aa1f601a
Author: Arun Mahadevan <ar...@apache.org>
Date: 2016-12-08T15:48:12Z
[STORM-2238] Add Timestamp extractor for windowed bolt
Added a timestamp extractor so that the tuple timestamp can be derived from the tuple than directly
mapping it to a field within the tuple.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1820: [STORM-2238] Add Timestamp extractor for windowed bolt
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1820
@HeartSaVioR good point. Old api is retained, added additional doc for new api in docs/Windowing.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1820: [STORM-2238] Add Timestamp extractor for windowed bolt
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1820
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1820: [STORM-2238] Add Timestamp extractor for windowed ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1820
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1820: [STORM-2238] Add Timestamp extractor for windowed bolt
Posted by hmcl <gi...@git.apache.org>.
Github user hmcl commented on the issue:
https://github.com/apache/storm/pull/1820
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1820: [STORM-2238] Add Timestamp extractor for windowed bolt
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1820
@arunmahadevan Thanks for the quick update. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1820: [STORM-2238] Add Timestamp extractor for windowed bolt
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1820
@arunmahadevan
Didn't we have document around setting up timestamp field? I think we should have it, or if we did, it should be updated.
Other than that it looks great overall.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---