[GitHub] [airflow] potiuk commented on pull request #26579: Fix bad test for unknown hook type

[GitBox <gi...@apache.org>]

potiuk commented on PR #26579:
URL: https://github.com/apache/airflow/pull/26579#issuecomment-1254625487

   > It is a bit strange that it wouldn't failed earlier in #25980
   
   It has not failed because we have selective checks that only run porvider's tests for those "changed providers" and those that "depend" on them. 
   
   Technically speaking we would run automatically "amazon" tests if "|common.sql" changed (because amazon depends on common.sql):
   
   https://github.com/apache/airflow/blob/main/generated/provider_dependencies.json#L35
   
   But we would not run "common.sql" tests when "amazon" changes because "common.sql" does not depend on amazon:
   
   https://github.com/apache/airflow/blob/main/generated/provider_dependencies.json#L199
   
   The problem in this case was that we had implicit dependency of common.sql "tests" on "amazon" provider - because in the common.sql we were using s3 as example connection, so there was a hidden dependency of "common.sql" tests on "amazon" :).
   
   So actually failing main was our "canary" tests failing showing that there was a test that slipped through the safety net. This is the price to pay for the optimisations we have  (we run a small set of provider test now when only providers change  - that saves a lot of time and build hours).
   
   The change now changed it to "fs", so we are good as "fs" is not a separate provider but it is part of Airlfow so the impiicit dependency is gone.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org