You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/10/26 07:01:45 UTC
[GitHub] [iceberg] pvary commented on a diff in pull request #6049: Flink: Add Sink options to override the compression properties of the Table
pvary commented on code in PR #6049:
URL: https://github.com/apache/iceberg/pull/6049#discussion_r1005293284
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkConfParser.java:
##########
@@ -139,7 +139,6 @@ public StringConfParser defaultValue(String value) {
}
public String parse() {
- Preconditions.checkArgument(defaultValue != null, "Default value cannot be null");
Review Comment:
The default value for `AVRO_COMPRESSION_LEVEL_DEFAULT`, `PARQUET_COMPRESSION_LEVEL_DEFAULT` is `null`, so we do not have default values there
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkConfParser.java:
##########
@@ -139,7 +139,6 @@ public StringConfParser defaultValue(String value) {
}
public String parse() {
- Preconditions.checkArgument(defaultValue != null, "Default value cannot be null");
Review Comment:
Ohh..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org