[PR] Refactor AgentPathTest to support jdk26 [shardingsphere]

["jiangML (via GitHub)" <gi...@apache.org>]

jiangML opened a new pull request, #38656:
URL: https://github.com/apache/shardingsphere/pull/38656

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     - Refactor AgentPathTest to support jdk26
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor AgentPathTest to support jdk26 [shardingsphere]

["jiangML (via GitHub)" <gi...@apache.org>]

jiangML commented on PR #38656:
URL: https://github.com/apache/shardingsphere/pull/38656#issuecomment-4333355170

   Merge Verdict: Mergeable.
   
   The latest PR head is in good shape for merge. It now fixes the earlier blocker by restoring public-behavior testing while removing the JDK26-fragile test hack:
   
   AgentPath now accepts an injected classloader: getRootPath(final ClassLoader classLoader).
   ShardingSphereAgent.premain(...) explicitly passes ClassLoader.getSystemClassLoader(), so runtime behavior remains aligned with previous semantics.
   AgentPathTest now directly validates the public method across key branches (success, missing jar, malformed URL), instead of testing private internals only.
   Risk scan result:
   
   Scope is limited to agent/core; no shared SQL/parser/binder/routing path touched.
   No cross-dialect blast-radius concern applies.
   No new config-flag/disabled-path risk introduced.
   Verification:
   
   Module-scoped test run with dependencies (-am) passed:
   ./mvnw -pl agent/core -am -Dtest=AgentPathTest,ShardingSphereAgentTest -Dsurefire.failIfNoSpecifiedTests=false -DskipITs -Dspotless.skip=true test
   Exit code: 0
   Compared with the previous review round:
   
   Previous blocker is resolved.
   No new blockers found.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Refactor AgentPath and AgentPathTest to support jdk26 [shardingsphere]

["RaigorJiang (via GitHub)" <gi...@apache.org>]

RaigorJiang merged PR #38656:
URL: https://github.com/apache/shardingsphere/pull/38656


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org