You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by tianyi <gi...@git.apache.org> on 2015/07/13 14:54:34 UTC
[GitHub] phoenix pull request: PHOENIX-2112 support UTF8String for spark 1....
GitHub user tianyi opened a pull request:
https://github.com/apache/phoenix/pull/100
PHOENIX-2112 support UTF8String for spark 1.4.0
In Spark 1.4.0, Phoenix-Spark will throw an exception when we put a filter like `a='a'` , because phoenix did not recognize `UTF8String` as a String Type, and then transform this expression to a=a
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tianyi/phoenix PHOENIX-2112
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit 1d3648a0adeed2f6ce787c41b087d8238a1fa348
Author: Yi Tian <ti...@gmail.com>
Date: 2015-07-13T12:52:40Z
Update PhoenixRelation.scala
Add `UTF8String` support.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2112 support UTF8String for spark 1....
Posted by tianyi <gi...@git.apache.org>.
Github user tianyi commented on the pull request:
https://github.com/apache/phoenix/pull/100#issuecomment-121160165
@jmahonin , your patch is the same with the changes in our internal version.
It works well under Spark 1.4.0
Should I add the `spark.version` changes in `pom.xml` in this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2112 support UTF8String for spark 1....
Posted by jmahonin <gi...@git.apache.org>.
Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/100#issuecomment-121215183
@tianyi Fantastic. Your patch has already been committed here, so don't worry about adjusting this PR:
https://github.com/apache/phoenix/commit/70c542d8e7b8bdcea58e2ef8cbf76143ec5ae66c
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2112 support UTF8String for spark 1....
Posted by jmahonin <gi...@git.apache.org>.
Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/100#issuecomment-121979444
Yup, we've got it in for the next release. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2112 support UTF8String for spark 1....
Posted by tianyi <gi...@git.apache.org>.
Github user tianyi commented on the pull request:
https://github.com/apache/phoenix/pull/100#issuecomment-121978717
Should I close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2112 support UTF8String for spark 1....
Posted by jmahonin <gi...@git.apache.org>.
Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/100#issuecomment-120925695
Thanks for the patch. I'll look into getting this in ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2112 support UTF8String for spark 1....
Posted by jmahonin <gi...@git.apache.org>.
Github user jmahonin commented on the pull request:
https://github.com/apache/phoenix/pull/100#issuecomment-120999971
@tianyi Could you try out the revised patch on the ticket [1], and let me know if it works for you?
[1] https://issues.apache.org/jira/browse/PHOENIX-2112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] phoenix pull request: PHOENIX-2112 support UTF8String for spark 1....
Posted by tianyi <gi...@git.apache.org>.
Github user tianyi closed the pull request at:
https://github.com/apache/phoenix/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---