You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2013/06/11 21:55:11 UTC
svn commit: r1491926 - in /commons/proper/chain/trunk/core/src:
main/java/org/apache/commons/chain2/impl/ChainBase.java
test/java/org/apache/commons/chain2/impl/ChainBaseTestCase.java
Author: britter
Date: Tue Jun 11 19:55:11 2013
New Revision: 1491926
URL: http://svn.apache.org/r1491926
Log:
Fix failing test
Modified:
commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java
commons/proper/chain/trunk/core/src/test/java/org/apache/commons/chain2/impl/ChainBaseTestCase.java
Modified: commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java
URL: http://svn.apache.org/viewvc/commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java?rev=1491926&r1=1491925&r2=1491926&view=diff
==============================================================================
--- commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java (original)
+++ commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java Tue Jun 11 19:55:11 2013
@@ -92,7 +92,9 @@ public class ChainBase<K, V, C extends M
if (commands == null) {
throw new IllegalArgumentException();
}
- this.commands.addAll( commands );
+ for (Command<K, V, C> command : commands) {
+ addCommand( command );
+ }
}
// ----------------------------------------------------- Instance Variables
Modified: commons/proper/chain/trunk/core/src/test/java/org/apache/commons/chain2/impl/ChainBaseTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/chain/trunk/core/src/test/java/org/apache/commons/chain2/impl/ChainBaseTestCase.java?rev=1491926&r1=1491925&r2=1491926&view=diff
==============================================================================
--- commons/proper/chain/trunk/core/src/test/java/org/apache/commons/chain2/impl/ChainBaseTestCase.java (original)
+++ commons/proper/chain/trunk/core/src/test/java/org/apache/commons/chain2/impl/ChainBaseTestCase.java Tue Jun 11 19:55:11 2013
@@ -367,7 +367,6 @@ public class ChainBaseTestCase {
}
@Test(expected = IllegalArgumentException.class)
- @Ignore // FIXME this one fails although javadoc says it shouldn't
public void testConstructorCollectionWithNullElements() throws Exception {
List<Command<String, Object, Context<String, Object>>> commands = new ArrayList<Command<String, Object, Context<String, Object>>>();
commands.add(new DelegatingFilter("1", "a"));