You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Mingliang Liu (JIRA)" <ji...@apache.org> on 2015/10/26 23:00:28 UTC
[jira] [Updated] (HADOOP-12514) Make static fields in
GenericTestUtils for assertExceptionContains() package-private and final
[ https://issues.apache.org/jira/browse/HADOOP-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mingliang Liu updated HADOOP-12514:
-----------------------------------
Status: Patch Available (was: Open)
> Make static fields in GenericTestUtils for assertExceptionContains() package-private and final
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-12514
> URL: https://issues.apache.org/jira/browse/HADOOP-12514
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Priority: Minor
> Attachments: HADOOP-12514.000.patch
>
>
> This is a follow up of [HADOOP-12472].
> It makes sense to make the following static fields package private instead of protected, as they are for test purpose (protected keyword makes more sense to sub-classes).
> - protected static String E_NULL_THROWABLE = "Null Throwable";
> - protected static String E_NULL_THROWABLE_STRING = "Null Throwable.toString() value";
> - protected static String E_UNEXPECTED_EXCEPTION = "but got unexpected exception";
> Meanwhile, we may need to make them final.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)