You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/03/01 04:47:18 UTC
[GitHub] [iceberg] hililiwei opened a new pull request #4246: Flink: Add support for ResolvedSchema
hililiwei opened a new pull request #4246:
URL: https://github.com/apache/iceberg/pull/4246
Some tasks in our production environment have been migrated to Schema/ResolvedSchema. This PR is mainly used to add support for ResolvedSchema.
1. Add the following `project` to the source:
```java
public Builder project(ResolvedSchema schema) {
this.projectedResolvedSchema = schema;
return this;
}
```
2. Add the following code to the sink:
```java
public Builder tableSchema(ResolvedSchema newTableSchema) {
this.resolvedTableSchema = newTableSchema;
return this;
}
```
3. FlinkDynamicTableFactory replaces CatalogTable with ResolvedSchema and uses it in `IcebergTableSource`and `IcebergTableSink`.
4. Add a tool class for ResolvedSchema: FlinkResolvedSchemaUtil. Convert the flink table schema to apache iceberg schema.
5. Add simple test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #4246: Flink: Add support for ResolvedSchema
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #4246:
URL: https://github.com/apache/iceberg/pull/4246#discussion_r817304711
##########
File path: flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java
##########
@@ -71,14 +69,6 @@
.noDefaultValue()
.withDescription("Table name managed in the underlying iceberg catalog and database.");
- // Flink 1.13.x change the return type from CatalogTable interface to ResolvedCatalogTable which extends the
- // CatalogTable. Here we use the dynamic method loading approach to avoid adding explicit CatalogTable or
- // ResolvedCatalogTable class into the iceberg-flink-runtime jar for compatibility purpose.
- private static final DynMethods.UnboundMethod GET_CATALOG_TABLE = DynMethods.builder("getCatalogTable")
- .impl(Context.class, "getCatalogTable")
- .orNoop()
- .build();
Review comment:
Good catch @hililiwei!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org