You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/30 19:53:39 UTC

[GitHub] [airflow] jedcunningham edited a comment on pull request #22627: Do not log the hook password even at DEBUG level

jedcunningham edited a comment on pull request #22627:
URL: https://github.com/apache/airflow/pull/22627#issuecomment-1083561752


   The way `extra` is masked based on key covers the edge cases I'm aware of (in this case, MASK_SECRETS_IN_LOGS being False). There easily could be others though 🤷‍♂️.
   
   That said, I'm thinking we should just remove this DEBUG log in its entirety. We already INFO the conn_id, which should be sufficient for debugging purposes imo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org