You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/03/05 07:32:20 UTC
[GitHub] [druid] abhishekagarwal87 opened a new pull request #10947: Add flag in SQL to disable left base filter optimization for joins
abhishekagarwal87 opened a new pull request #10947:
URL: https://github.com/apache/druid/pull/10947
Follow up #10697 where we added an optimization to push joins to historicals when left child is a scan with a filter. However, the change could actually underperform depending on the kind of query. This PR introduces a flag to switch between two behaviors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #10947: Add flag in SQL to disable left base filter optimization for joins
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #10947:
URL: https://github.com/apache/druid/pull/10947#discussion_r589956145
##########
File path: processing/src/main/java/org/apache/druid/query/QueryContexts.java
##########
@@ -54,6 +55,10 @@
public static final String JOIN_FILTER_REWRITE_ENABLE_KEY = "enableJoinFilterRewrite";
public static final String JOIN_FILTER_REWRITE_VALUE_COLUMN_FILTERS_ENABLE_KEY = "enableJoinFilterRewriteValueColumnFilters";
public static final String JOIN_FILTER_REWRITE_MAX_SIZE_KEY = "joinFilterRewriteMaxSize";
+ // This flag control whether a sql join query with left scan should be attempted to be run as direct table access
+ // instead of being wrapped inside a query. With direct table access enabled, druid can push down the join operation to
+ // data servers.
+ public static final String SQL_JOIN_LEFT_SCAN_DIRECT = "enableSQLLeftTableScanDirect";
Review comment:
this should maybe be `enableJoinLeftTableScanDirect` to be more consistent with other join related query context parameters. I also think it should probably be documented, but none of the other join query context parameters are documented (not sure why), so not sure its a blocker for this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on pull request #10947: Add flag in SQL to disable left base filter optimization for joins
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on pull request #10947:
URL: https://github.com/apache/druid/pull/10947#issuecomment-793837481
k8s integration test failed which is unrelated to changes in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm merged pull request #10947: Add flag in SQL to disable left base filter optimization for joins
Posted by GitBox <gi...@apache.org>.
maytasm merged pull request #10947:
URL: https://github.com/apache/druid/pull/10947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org