[jira] [Commented] (CLOUDSTACK-10380) changing passwordenabled to true while guest vm is running causes unexpected passwordreset again in startvm

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543327#comment-16543327 ] 

ASF GitHub Bot commented on CLOUDSTACK-10380:
---------------------------------------------

smeetsr opened a new pull request #2743: CLOUDSTACK-10380: Fix startvm giving another pw after pw reset
URL: https://github.com/apache/cloudstack/pull/2743
 
 
   ## Description
   <!--- Describe your changes in detail -->
   * When password reset is called, and VR accepts it, set vm updateParameters to false.
   * When password reset is called, and SSH key is set, make sure the password isn't removed again.
   * Fix Marvin tests
   * Make sure saveDetails keeps the display value of the existing details.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [x] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   Manual + automated marvin nuagevsp tests + component config drive
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
   - [x] I have read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document.
   - [x] My code follows the code style of this project.
   - [ ] My change requires a change to the documentation.
   - [ ] I have updated the documentation accordingly.
   Testing
   - [x] I have added tests to cover my changes.
   - [ ] All relevant new and existing integration tests have passed.
   - [ ] A full integration testsuite with all test that can run on my environment has passed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> changing passwordenabled to true while guest vm is running causes unexpected passwordreset again in startvm
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10380
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10380
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.12, 4.11.1.0
>            Reporter: Raf Smeets
>            Assignee: Frank Maximus
>            Priority: Major
>
> changing passwordenabled to true while guest vm is running causes passwordreset again in startvm
> Steps to reproduce:
>  # Template passwordenabled flag is set to false
>  # Start Vm
>  # Set template passwordenabled flag to true
>  # StopVm
>  # ResetPassword for Stopped Vm. Password is PasswordA.
>  # StartVm. Password is PasswordB.  This should not happen!!
>  # SSH into VM only works with PasswordB.
> Next steps are as expected.
>  # StopVm
>  # ResetPassword for Stopped Vm. Password is PasswordC.
>  # 1StartVm. No change in password.
>  # SSH into VM works with PasswordC.
> This was found when test/integration/plugins/nuagevsp/test_nuage_passwordreset.py started to fail after merging of PR2651 [https://github.com/apache/cloudstack/pull/2651].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)