You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Yash Sharma <ya...@gmail.com> on 2015/07/04 13:06:31 UTC
Review Request 36178: LENS-634 : File name suggestions in cli when
path is expected
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
Review request for lens.
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
Will be sharing full build results soon.
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 4, 2015, 2:01 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 21
> > <https://reviews.apache.org/r/36178/diff/1/?file=999115#file999115line21>
> >
> > There are other files too that need file path. query command needs for result storing. metastore commands have create command which needs file name. etc.
Thanks.
Have added changes for the ones I could spot. Do let me know in case i missed any commands.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review90385
-----------------------------------------------------------
On July 4, 2015, 6:25 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 4, 2015, 6:25 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.076 s]
> [INFO] Lens ............................................... SUCCESS [ 2.687 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.435 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.664 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:15 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.368 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.793 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.684 s]
> [INFO] Lens Server ........................................ SUCCESS [05:16 min]
> [INFO] Lens client ........................................ SUCCESS [ 39.897 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:14 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.767 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.144 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:16 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.218 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.612 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:46 min
> [INFO] Finished at: 2015-07-04T16:52:09+05:30
> [INFO] Final Memory: 125M/401M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review90385
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (line 21)
<https://reviews.apache.org/r/36178/#comment143439>
There are other files too that need file path. query command needs for result storing. metastore commands have create command which needs file name. etc.
- Rajat Khandelwal
On July 4, 2015, 4:52 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 4, 2015, 4:52 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.076 s]
> [INFO] Lens ............................................... SUCCESS [ 2.687 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.435 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.664 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:15 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.368 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.793 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.684 s]
> [INFO] Lens Server ........................................ SUCCESS [05:16 min]
> [INFO] Lens client ........................................ SUCCESS [ 39.897 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:14 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.767 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.144 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:16 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.218 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.612 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:46 min
> [INFO] Finished at: 2015-07-04T16:52:09+05:30
> [INFO] Final Memory: 125M/401M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 6, 2015, 6:24 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 146
> > <https://reviews.apache.org/r/36178/diff/2/?file=999125#file999125line146>
> >
> > Can you make sure all possible scenarios are covered by checking usages of this function? Wherever this function is used, we have a possible place where String can be changed to File.
> >
> > Also can you verify commands that expect directory path work fine? e.g. query results.
Implemented.
> On July 6, 2015, 6:24 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 148
> > <https://reviews.apache.org/r/36178/diff/2/?file=999125#file999125line148>
> >
> > Can we avoid explicit check by using `@NonNull` either here of in the command arguments where `File` object is argument.
+1.
> On July 6, 2015, 6:24 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 101
> > <https://reviews.apache.org/r/36178/diff/2/?file=999126#file999126line101>
> >
> > I'm not sure, but shouldn't we do `path.getPath` here? Can you verify by passing both default path -- absolute and relative -- and fully qualified path?
> >
> > 1. add jar local/path
> > 2. add jar /full/path
> > 3. add jar file:///full/path
> > 4. add jar file://local/path
> >
> > Can probably add these to test cases.
It was defenitely a typo. Fixed now.
The existing testcases actually cover these scenarios.
> On July 6, 2015, 6:24 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java, line 60
> > <https://reviews.apache.org/r/36178/diff/2/?file=999127#file999127line60>
> >
> > `create` can probably take a `File` object now. This can propagate all the way upto `LensMetadataClient`. Similarly for other functions.
> >
> > I'm just suggesting based on my understanding of the modules. If making this change might break something, we can leave it. But it'll be good to have an understanding of why we can or can't make such a change.
Added changes. Let me know if I might have missed any methods.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review90446
-----------------------------------------------------------
On July 15, 2015, 5:33 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 15, 2015, 5:33 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> New build results-
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
> [INFO] Lens ............................................... SUCCESS [ 2.842 s]
> [INFO] Lens API ........................................... SUCCESS [ 21.035 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.545 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:04 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.023 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.263 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:28 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.581 s]
> [INFO] Lens Server ........................................ SUCCESS [05:10 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.137 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:06 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.193 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.860 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.114 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.437 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:15 min
> [INFO] Finished at: 2015-07-05T00:12:45+05:30
> [INFO] Final Memory: 125M/375M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review90446
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 146)
<https://reviews.apache.org/r/36178/#comment143492>
Can you make sure all possible scenarios are covered by checking usages of this function? Wherever this function is used, we have a possible place where String can be changed to File.
Also can you verify commands that expect directory path work fine? e.g. query results.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 148)
<https://reviews.apache.org/r/36178/#comment143493>
Can we avoid explicit check by using `@NonNull` either here of in the command arguments where `File` object is argument.
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (line 101)
<https://reviews.apache.org/r/36178/#comment143494>
I'm not sure, but shouldn't we do `path.getPath` here? Can you verify by passing both default path -- absolute and relative -- and fully qualified path?
1. add jar local/path
2. add jar /full/path
3. add jar file:///full/path
4. add jar file://local/path
Can probably add these to test cases.
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java (line 60)
<https://reviews.apache.org/r/36178/#comment143495>
`create` can probably take a `File` object now. This can propagate all the way upto `LensMetadataClient`. Similarly for other functions.
I'm just suggesting based on my understanding of the modules. If making this change might break something, we can leave it. But it'll be good to have an understanding of why we can or can't make such a change.
- Rajat Khandelwal
On July 5, 2015, 12:18 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 5, 2015, 12:18 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> New build results-
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
> [INFO] Lens ............................................... SUCCESS [ 2.842 s]
> [INFO] Lens API ........................................... SUCCESS [ 21.035 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.545 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:04 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.023 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.263 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:28 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.581 s]
> [INFO] Lens Server ........................................ SUCCESS [05:10 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.137 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:06 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.193 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.860 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.114 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.437 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:15 min
> [INFO] Finished at: 2015-07-05T00:12:45+05:30
> [INFO] Final Memory: 125M/375M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 17, 2015, 5:13 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 194
> > <https://reviews.apache.org/r/36178/diff/3/?file=1012791#file1012791line194>
> >
> > What is the behaviour of cli on optional File arguments? What gets passed to the method? `null` or `new File("")`? If it's `null`, we'll have to modify all test cases (and possibly code) to behave proper for that.
>
> Yash Sharma wrote:
> Oh gosh, this is a huge bug in here. @NonNull makes this field sort-of required field. It adds a null check at the beginning of the method and blows up with NPE if not provided. I have no clue how I missed this !
>
> This means that we will have to take care of the null checks ourselves in the code. Will work over it in the weekend and patch back.
Added bugfix for scenario where path might be optional.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92101
-----------------------------------------------------------
On July 19, 2015, 10:40 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 10:40 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 s]
> [INFO] Lens ............................................... SUCCESS [ 4.348 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.880 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.195 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 13.843 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 s]
> [INFO] Lens Server ........................................ SUCCESS [05:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.162 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:10 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.574 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.600 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.166 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:05 min
> [INFO] Finished at: 2015-07-19T16:00:17+05:30
> [INFO] Final Memory: 130M/428M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 17, 2015, 5:13 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java, line 220
> > <https://reviews.apache.org/r/36178/diff/3/?file=1012781#file1012781line220>
> >
> > This check is not required. path.getPath will never be null.
The check is also responsible for returning a proper message where the plan is stored rather than returning the plan for printing on console, so looks legit -
"Saved to " + <PATH>
> On July 17, 2015, 5:13 p.m., Rajat Khandelwal wrote:
> > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line 194
> > <https://reviews.apache.org/r/36178/diff/3/?file=1012791#file1012791line194>
> >
> > What is the behaviour of cli on optional File arguments? What gets passed to the method? `null` or `new File("")`? If it's `null`, we'll have to modify all test cases (and possibly code) to behave proper for that.
Oh gosh, this is a huge bug in here. @NonNull makes this field sort-of required field. It adds a null check at the beginning of the method and blows up with NPE if not provided. I have no clue how I missed this !
This means that we will have to take care of the null checks ourselves in the code. Will work over it in the weekend and patch back.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92101
-----------------------------------------------------------
On July 17, 2015, 5:08 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 17, 2015, 5:08 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.135 s]
> [INFO] Lens ............................................... SUCCESS [ 2.813 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.590 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.734 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:42 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.573 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.858 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:37 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.645 s]
> [INFO] Lens Server ........................................ SUCCESS [04:54 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.606 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:11 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.632 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.609 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.390 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:58 min
> [INFO] Finished at: 2015-07-17T22:32:49+05:30
> [INFO] Final Memory: 126M/393M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92101
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java (line 220)
<https://reviews.apache.org/r/36178/#comment146042>
This check is not required. path.getPath will never be null.
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 194)
<https://reviews.apache.org/r/36178/#comment146043>
What is the behaviour of cli on optional File arguments? What gets passed to the method? `null` or `new File("")`? If it's `null`, we'll have to modify all test cases (and possibly code) to behave proper for that.
- Rajat Khandelwal
On July 17, 2015, 10:38 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 17, 2015, 10:38 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.135 s]
> [INFO] Lens ............................................... SUCCESS [ 2.813 s]
> [INFO] Lens API ........................................... SUCCESS [ 20.590 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.734 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:42 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.573 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.858 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:37 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.645 s]
> [INFO] Lens Server ........................................ SUCCESS [04:54 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.606 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:11 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.632 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.609 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.390 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:58 min
> [INFO] Finished at: 2015-07-17T22:32:49+05:30
> [INFO] Final Memory: 126M/393M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 20, 2015, 6:04 p.m., Raju Bairishetti wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 155
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line155>
> >
> > **newPath.startsWith("file:/")** check is redundant.
he's checking if path is `file:/x/y/z` and not `file:///x/y/z`, in that case, convert it to `file:///x/y/z`.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92259
-----------------------------------------------------------
On July 19, 2015, 4:10 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 4:10 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 s]
> [INFO] Lens ............................................... SUCCESS [ 4.348 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.880 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.195 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 13.843 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 s]
> [INFO] Lens Server ........................................ SUCCESS [05:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.162 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:10 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.574 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.600 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.166 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:05 min
> [INFO] Finished at: 2015-07-19T16:00:17+05:30
> [INFO] Final Memory: 130M/428M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 20, 2015, 12:34 p.m., Raju Bairishetti wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 155
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line155>
> >
> > **newPath.startsWith("file:/")** check is redundant.
>
> Rajat Khandelwal wrote:
> he's checking if path is `file:/x/y/z` and not `file:///x/y/z`, in that case, convert it to `file:///x/y/z`.
>
> Rajat Khandelwal wrote:
> Yes. This is redundant.
Can you provide more info on this. If i am not wrong its redundant because of the index check along with startsWith check ? Right ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92259
-----------------------------------------------------------
On July 22, 2015, 2:29 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 2:29 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 s]
> [INFO] Lens ............................................... SUCCESS [ 10.092 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.157 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:36 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.628 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.736 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 s]
> [INFO] Lens Server ........................................ SUCCESS [04:49 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.127 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:43 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.946 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.965 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.781 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:21 min
> [INFO] Finished at: 2015-07-22T19:27:26+05:30
> [INFO] Final Memory: 130M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
Thanks Raju & Rajat for the comments. Will look into it tonight and post
updates.
Best Regards
On Tue, Jul 21, 2015 at 12:17 PM, Rajat Khandelwal <ra...@gmail.com>
wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
>
> On July 20th, 2015, 6:04 p.m. IST, *Raju Bairishetti* wrote:
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
> <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line155> (Diff
> revision 5)
>
> public static LensClientSingletonWrapper getClientWrapper() {
>
> 155
>
> if (newPath.startsWith("file:/") && !newPath.startsWith("file://")) {
>
> *newPath.startsWith("file:/")* check is redundant.
>
> On July 20th, 2015, 6:08 p.m. IST, *Rajat Khandelwal* wrote:
>
> he's checking if path is file:/x/y/z and not file:///x/y/z, in that case, convert it to file:///x/y/z.
>
> Yes. This is redundant.
>
>
> - Rajat
>
> On July 19th, 2015, 4:10 p.m. IST, Yash Sharma wrote:
> Review request for lens.
> By Yash Sharma.
>
> *Updated July 19, 2015, 4:10 p.m.*
> *Repository: * lens
> Description
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
> https://issues.apache.org/jira/browse/LENS-634
>
> Testing
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 s]
> [INFO] Lens ............................................... SUCCESS [ 4.348 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.880 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.195 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 13.843 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 s]
> [INFO] Lens Server ........................................ SUCCESS [05:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.162 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:10 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.574 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.600 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.166 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:05 min
> [INFO] Finished at: 2015-07-19T16:00:17+05:30
> [INFO] Final Memory: 130M/428M
> [INFO] -----------------------------------------------------------------------
>
> Diffs
>
> - lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java
> (74b4e91)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java
> (9cb7d69)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java
> (8b4face)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java
> (6ba702f)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java
> (de022c1)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java
> (6a93393)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java
> (bdb9c38)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java
> (c48fabd)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java
> (928120a)
> - lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java
> (a479c14)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java
> (7503221)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java
> (73661e1)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java
> (b6f96e6)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java
> (a22862e)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java
> (a87d0b7)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java
> (13bfbd2)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java
> (73f3a78)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java
> (46e28a9)
> - lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java
> (3a04ec6)
> - lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java
> (a5033fe)
> - lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java
> (92687c3)
> - lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java
> (715347f)
> - src/site/apt/user/cli.apt (353c171)
>
> View Diff <https://reviews.apache.org/r/36178/diff/>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 20, 2015, 6:04 p.m., Raju Bairishetti wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 155
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line155>
> >
> > **newPath.startsWith("file:/")** check is redundant.
>
> Rajat Khandelwal wrote:
> he's checking if path is `file:/x/y/z` and not `file:///x/y/z`, in that case, convert it to `file:///x/y/z`.
Yes. This is redundant.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92259
-----------------------------------------------------------
On July 19, 2015, 4:10 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 4:10 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 s]
> [INFO] Lens ............................................... SUCCESS [ 4.348 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.880 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.195 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 13.843 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 s]
> [INFO] Lens Server ........................................ SUCCESS [05:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.162 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:10 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.574 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.600 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.166 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:05 min
> [INFO] Finished at: 2015-07-19T16:00:17+05:30
> [INFO] Final Memory: 130M/428M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Raju Bairishetti <ra...@gmail.com>.
> On July 20, 2015, 12:34 p.m., Raju Bairishetti wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 155
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line155>
> >
> > **newPath.startsWith("file:/")** check is redundant.
>
> Rajat Khandelwal wrote:
> he's checking if path is `file:/x/y/z` and not `file:///x/y/z`, in that case, convert it to `file:///x/y/z`.
>
> Rajat Khandelwal wrote:
> Yes. This is redundant.
>
> Yash Sharma wrote:
> Can you provide more info on this. If i am not wrong its redundant because of the index check along with startsWith check ? Right ?
@yash yes
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92259
-----------------------------------------------------------
On July 22, 2015, 2:29 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 2:29 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 s]
> [INFO] Lens ............................................... SUCCESS [ 10.092 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.157 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:36 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.628 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.736 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 s]
> [INFO] Lens Server ........................................ SUCCESS [04:49 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.127 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:43 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.946 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.965 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.781 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:21 min
> [INFO] Finished at: 2015-07-22T19:27:26+05:30
> [INFO] Final Memory: 130M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92259
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 155)
<https://reviews.apache.org/r/36178/#comment146322>
**newPath.startsWith("file:/")** check is redundant.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 161)
<https://reviews.apache.org/r/36178/#comment146324>
Seems *newPath.startsWith("hdfs:/")* check is redundant
- Raju Bairishetti
On July 19, 2015, 10:40 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 10:40 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 s]
> [INFO] Lens ............................................... SUCCESS [ 4.348 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.880 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.195 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 13.843 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 s]
> [INFO] Lens Server ........................................ SUCCESS [05:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.162 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:10 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.574 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.600 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.166 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:05 min
> [INFO] Finished at: 2015-07-19T16:00:17+05:30
> [INFO] Final Memory: 130M/428M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 20, 2015, 1:48 p.m., Raju Bairishetti wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 150
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line150>
> >
> > Can we avoid the checks for each file system scheme(file, hdfs, s3...)? Can we find a way to get the scheme from the filepath itself and make changes accordingly?
> >
> > Hadoop FileSystem returns scheme using getScheme() method.
> >
> > @prongs @amareshwari thoughts?
Cannot use hadoop's filesystem until the URI is formatted, and the CLI appends a local dir prefix to the path and replaces all double slashes // with single slashes /.
Have avoided to some extent by adding :/// for all uri's in general and special handling for hdfs that would expect ://
Currently it wouldnot support s3/s3n patch with userid and key mentioned with ://
Need to devise some strategy for it.
Let me know your opinion on this.
> On July 20, 2015, 1:48 p.m., Raju Bairishetti wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 151
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line151>
> >
> > Can we move this above and use *newPath* wherever we use path.getPath()?
Changed design of util method. Let me know if it looks good.
> On July 20, 2015, 1:48 p.m., Raju Bairishetti wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 155
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line155>
> >
> > Yes, but we are already checking whether the path contains **file:/**. Looks like it is a redundant check.
+1. My Bad. Fixed now.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92264
-----------------------------------------------------------
On July 22, 2015, 2:29 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 2:29 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 s]
> [INFO] Lens ............................................... SUCCESS [ 10.092 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.157 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:36 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.628 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.736 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 s]
> [INFO] Lens Server ........................................ SUCCESS [04:49 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.127 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:43 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.946 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.965 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.781 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:21 min
> [INFO] Finished at: 2015-07-22T19:27:26+05:30
> [INFO] Final Memory: 130M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92264
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 150)
<https://reviews.apache.org/r/36178/#comment146330>
Can we avoid the checks for each file system scheme(file, hdfs, s3...)? Can we find a way to get the scheme from the filepath itself and make changes accordingly?
Hadoop FileSystem returns scheme using getScheme() method.
@prongs @amareshwari thoughts?
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 151)
<https://reviews.apache.org/r/36178/#comment146329>
Can we move this above and use *newPath* wherever we use path.getPath()?
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 155)
<https://reviews.apache.org/r/36178/#comment146328>
Yes, but we are already checking whether the path contains **file:/**. Looks like it is a redundant check.
- Raju Bairishetti
On July 19, 2015, 10:40 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 10:40 a.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 s]
> [INFO] Lens ............................................... SUCCESS [ 4.348 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.880 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.195 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 13.843 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 s]
> [INFO] Lens Server ........................................ SUCCESS [05:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.162 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:10 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.574 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.600 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.166 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:05 min
> [INFO] Finished at: 2015-07-19T16:00:17+05:30
> [INFO] Final Memory: 130M/428M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 150
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line150>
> >
> > Can we use function of `UtilityMethods`?
Rather than using Server's Util class which might had caused circular dependency - moved it to API module where it can be used by other modules.
> On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 146
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line146>
> >
> > Can be made static.
Made changes. Also be moved to ApiUtilityMethods for reuse.
> On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 169
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016041#file1016041line169>
> >
> > Does this quit the cli? If it does, we might need to do something else here.
It does not quit the CLI. It however shows error message like-
lens-shell>add jar hdfs://test
Command failed java.lang.RuntimeException: <Exception message here>
> On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java, line 62
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016045#file1016045line62>
> >
> > Can you update the cli behaviour in cases
> >
> > * path is passed
> > * non existing path is passed
> > * path not passed
> > * path passed but is to a random file.
> > * path to a directory is passed
> > * anything else?
> >
> > I just want to make sure existing things don't break.
> >
> > In the long term we might have to change our testing strategy for CLI. http://docs.spring.io/spring-shell/docs/current/reference/htmlsingle/#d4e253
Scenarios tested:
lens-shell>add file file:/usr/local/lens/README
Add resource succeeded
lens-shell>add file hdfs://localhost:9000/test/tempfiles/*
Add resource succeeded
lens-shell>add file hdfs:/localhost:9000/test/tempfiles/*
Add resource succeeded
lens-shell>add file hdfs:///localhost:9000/test/tempfiles/*
Add resource succeeded
lens-shell>add file hdfs:///test/tempfiles/*
Add resource has failed
lens-shell>add file file:/usr/local/lens/NON_EXISTING_PATH
Add resource has failed
lens-shell>add file --path
You should specify a default option (otherwise known as option 'path') for this command
lens-shell>add file
You should specify a default option (otherwise known as option 'path') for this command
lens-shell>add file file:/usr/local/lens/server/logs
Add resource succeeded
lens-shell>list resources
type=file path=file:///usr/local/lens/README
type=file path=hdfs://localhost:9000/test/tempfiles/tempdata_c.jar
type=file path=hdfs://localhost:9000/test/tempfiles/tempdata_c.jar
type=file path=hdfs://localhost:9000/test/tempfiles/tempdata_c.jar
type=file path=file:///usr/local/lens/server/logs/lensserver-requests.log
type=file path=file:///usr/local/lens/server/logs/lensserver.out.2015072121161437493595
type=file path=file:///usr/local/lens/server/logs/query-stats.log
type=file path=file:///usr/local/lens/server/logs/server.pid
type=file path=file:///usr/local/lens/server/logs/lensserver.log
> On July 20, 2015, 7:30 a.m., Rajat Khandelwal wrote:
> > src/site/apt/user/cli.apt, line 95
> > <https://reviews.apache.org/r/36178/diff/5/?file=1016063#file1016063line95>
> >
> > Can probably take care of these too if you have the time. Discussed on https://issues.apache.org/jira/browse/LENS-25.
> >
> > The documentation of debug and verbose commands looks out of place compared to other commands when seen through `mvn site:run`.
Fixed. The help param was passed twice.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92231
-----------------------------------------------------------
On July 22, 2015, 2:29 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 2:29 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 s]
> [INFO] Lens ............................................... SUCCESS [ 10.092 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.157 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:36 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.628 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.736 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 s]
> [INFO] Lens Server ........................................ SUCCESS [04:49 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.127 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:43 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.946 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.965 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.781 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:21 min
> [INFO] Finished at: 2015-07-22T19:27:26+05:30
> [INFO] Final Memory: 130M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92231
-----------------------------------------------------------
+1 on enforcing required args with `@NonNull`
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 146)
<https://reviews.apache.org/r/36178/#comment146275>
Can be made static.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 150)
<https://reviews.apache.org/r/36178/#comment146280>
Can we use function of `UtilityMethods`?
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 169)
<https://reviews.apache.org/r/36178/#comment146274>
Does this quit the cli? If it does, we might need to do something else here.
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java (line 62)
<https://reviews.apache.org/r/36178/#comment146276>
Can you update the cli behaviour in cases
* path is passed
* non existing path is passed
* path not passed
* path passed but is to a random file.
* path to a directory is passed
* anything else?
I just want to make sure existing things don't break.
In the long term we might have to change our testing strategy for CLI. http://docs.spring.io/spring-shell/docs/current/reference/htmlsingle/#d4e253
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java (line 160)
<https://reviews.apache.org/r/36178/#comment146281>
Now that we have this function, we can probably change `org.apache.lens.server.query.QueryExecutionServiceImpl#addSingleResourceToHive` to use this.
src/site/apt/user/cli.apt (line 95)
<https://reviews.apache.org/r/36178/#comment146282>
Can probably take care of these too if you have the time. Discussed on https://issues.apache.org/jira/browse/LENS-25.
The documentation of debug and verbose commands looks out of place compared to other commands when seen through `mvn site:run`.
- Rajat Khandelwal
On July 19, 2015, 4:10 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 19, 2015, 4:10 p.m.)
>
>
> Review request for lens.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
> src/site/apt/user/cli.apt 353c171
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 s]
> [INFO] Lens ............................................... SUCCESS [ 4.348 s]
> [INFO] Lens API ........................................... SUCCESS [ 19.880 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:41 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.195 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 13.843 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 s]
> [INFO] Lens Server ........................................ SUCCESS [05:03 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.162 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:10 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.574 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.600 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.166 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:05 min
> [INFO] Finished at: 2015-07-19T16:00:17+05:30
> [INFO] Final Memory: 130M/428M
> [INFO] -----------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92596
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java (line 24)
<https://reviews.apache.org/r/36178/#comment146796>
Can we have tests for this class?
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java (line 91)
<https://reviews.apache.org/r/36178/#comment146798>
remove TODO
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java (line 145)
<https://reviews.apache.org/r/36178/#comment146802>
Remove commented code?
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java (line 203)
<https://reviews.apache.org/r/36178/#comment146803>
Commented code?
src/site/apt/user/cli.apt (line 95)
<https://reviews.apache.org/r/36178/#comment146799>
+1
src/site/apt/user/cli.apt (line 281)
<https://reviews.apache.org/r/36178/#comment146801>
+1
- Rajat Khandelwal
On July 22, 2015, 7:59 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 7:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 s]
> [INFO] Lens ............................................... SUCCESS [ 10.092 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.157 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:36 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.628 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.736 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 s]
> [INFO] Lens Server ........................................ SUCCESS [04:49 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.127 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:43 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.946 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.965 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.781 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:21 min
> [INFO] Finished at: 2015-07-22T19:27:26+05:30
> [INFO] Final Memory: 130M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 27, 2015, 9:12 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java, line 68
> > <https://reviews.apache.org/r/36178/diff/6-7/?file=1018821#file1018821line68>
> >
> > Why this change? Regular expression seems fishy to me. Can you explain? Won't `/+` work too? And why are we replacing `//////` with `/`?
Yes /+ should work. The only purpose is to replace all multiple slashes with a single slash. This is the way the CLI sends the paths. Also this will let us handle anypath that has extra slashes erronously like hdfs://// or s3://///
Will update the patch and post back.
> On July 27, 2015, 9:12 a.m., Rajat Khandelwal wrote:
> > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java, lines 73-87
> > <https://reviews.apache.org/r/36178/diff/7/?file=1021880#file1021880line73>
> >
> > Separate tests can be separate methods. Thus making them modular.
> >
> > If a test will throw exception. Please use `@Test(expectedExceptions = ...)` instead of catch and assert.
Cool. Will implement. Thanks.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93101
-----------------------------------------------------------
On July 25, 2015, 1:08 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 25, 2015, 1:08 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.260 s]
> [INFO] Lens ............................................... SUCCESS [ 2.762 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.013 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.134 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:53 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.727 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.522 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.807 s]
> [INFO] Lens Server ........................................ SUCCESS [05:00 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.785 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.077 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.065 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.631 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.392 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:57 min
> [INFO] Finished at: 2015-07-25T18:33:51+05:30
> [INFO] Final Memory: 130M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 27, 2015, 9:12 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java, line 68
> > <https://reviews.apache.org/r/36178/diff/6-7/?file=1018821#file1018821line68>
> >
> > Why this change? Regular expression seems fishy to me. Can you explain? Won't `/+` work too? And why are we replacing `//////` with `/`?
>
> Yash Sharma wrote:
> Yes /+ should work. The only purpose is to replace all multiple slashes with a single slash. This is the way the CLI sends the paths. Also this will let us handle anypath that has extra slashes erronously like hdfs://// or s3://///
>
> Will update the patch and post back.
>
> Rajat Khandelwal wrote:
> I think an altogether new scheme which does use say, 4 slashes will need to be handled separately by us. But since we're already doing special handling for hdfs, it's okay. But Let's at least document what pattern of schemes would be supported.
Added comments. Also changed the way special handling is implemented for ease of extensions.
Let me know your thoughts.
> On July 27, 2015, 9:12 a.m., Rajat Khandelwal wrote:
> > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java, lines 73-87
> > <https://reviews.apache.org/r/36178/diff/7/?file=1021880#file1021880line73>
> >
> > Separate tests can be separate methods. Thus making them modular.
> >
> > If a test will throw exception. Please use `@Test(expectedExceptions = ...)` instead of catch and assert.
>
> Yash Sharma wrote:
> Cool. Will implement. Thanks.
Done !!
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93101
-----------------------------------------------------------
On July 27, 2015, 7:56 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 7:56 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt a28d8a4
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.939 s]
> [INFO] Lens ............................................... SUCCESS [ 2.711 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.300 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.875 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:27 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.550 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.160 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.568 s]
> [INFO] Lens Server ........................................ SUCCESS [04:56 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.044 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:06 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.571 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.236 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.492 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.130 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:27 min
> [INFO] Finished at: 2015-07-28T01:21:57+05:30
> [INFO] Final Memory: 130M/382M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On July 27, 2015, 2:42 p.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java, line 68
> > <https://reviews.apache.org/r/36178/diff/6-7/?file=1018821#file1018821line68>
> >
> > Why this change? Regular expression seems fishy to me. Can you explain? Won't `/+` work too? And why are we replacing `//////` with `/`?
>
> Yash Sharma wrote:
> Yes /+ should work. The only purpose is to replace all multiple slashes with a single slash. This is the way the CLI sends the paths. Also this will let us handle anypath that has extra slashes erronously like hdfs://// or s3://///
>
> Will update the patch and post back.
I think an altogether new scheme which does use say, 4 slashes will need to be handled separately by us. But since we're already doing special handling for hdfs, it's okay. But Let's at least document what pattern of schemes would be supported.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93101
-----------------------------------------------------------
On July 25, 2015, 6:38 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 25, 2015, 6:38 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.260 s]
> [INFO] Lens ............................................... SUCCESS [ 2.762 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.013 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.134 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:53 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.727 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.522 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.807 s]
> [INFO] Lens Server ........................................ SUCCESS [05:00 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.785 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.077 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.065 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.631 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.392 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:57 min
> [INFO] Finished at: 2015-07-25T18:33:51+05:30
> [INFO] Final Memory: 130M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93101
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java (line 68)
<https://reviews.apache.org/r/36178/#comment147355>
Why this change? Regular expression seems fishy to me. Can you explain? Won't `/+` work too? And why are we replacing `//////` with `/`?
lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java (lines 73 - 87)
<https://reviews.apache.org/r/36178/#comment147356>
Separate tests can be separate methods. Thus making them modular.
If a test will throw exception. Please use `@Test(expectedExceptions = ...)` instead of catch and assert.
- Rajat Khandelwal
On July 25, 2015, 6:38 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 25, 2015, 6:38 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.260 s]
> [INFO] Lens ............................................... SUCCESS [ 2.762 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.013 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.134 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:53 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.727 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.522 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.807 s]
> [INFO] Lens Server ........................................ SUCCESS [05:00 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.785 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:04 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.077 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.065 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.631 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.392 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 17:57 min
> [INFO] Finished at: 2015-07-25T18:33:51+05:30
> [INFO] Final Memory: 130M/389M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 29, 2015, 11:58 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 105
> > <https://reviews.apache.org/r/36178/diff/9-10/?file=1023418#file1023418line105>
> >
> > add jar is supposed to be happening on server side. So the file is not expected to be present on client machine. Let's not call `getValidPath` here.
Added removePrefix since the prefix is injected by the cli and its best if its removed there.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93429
-----------------------------------------------------------
On Aug. 1, 2015, 6:16 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 6:16 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93429
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (line 104)
<https://reviews.apache.org/r/36178/#comment147793>
add jar is supposed to be happening on server side. So the file is not expected to be present on client machine. Let's not call `getValidPath` here.
- Rajat Khandelwal
On July 29, 2015, 2:51 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 2:51 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt a28d8a4
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.073 s]
> [INFO] Lens ............................................... SUCCESS [ 2.919 s]
> [INFO] Lens API ........................................... SUCCESS [ 24.629 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 24.005 s]
> [INFO] Lens Cube .......................................... SUCCESS [06:03 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.249 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 16.129 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:42 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.475 s]
> [INFO] Lens Server ........................................ SUCCESS [05:53 min]
> [INFO] Lens client ........................................ SUCCESS [ 43.273 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:24 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 10.744 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.569 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:39 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.106 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.772 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 22:10 min
> [INFO] Finished at: 2015-07-29T14:38:55+05:30
> [INFO] Final Memory: 130M/400M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review94068
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 120)
<https://reviews.apache.org/r/36178/#comment148568>
Remove commented code.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (lines 184 - 185)
<https://reviews.apache.org/r/36178/#comment148569>
Can we safely assume it'll never be null? The non null check can be added in client's constructor at the end. use `Preconditions.checkArgument` for valid state creation.
lens-client/src/main/java/org/apache/lens/client/LensClient.java (line 237)
<https://reviews.apache.org/r/36178/#comment148571>
Since this is the only place `pathValidator` is being created, And going up the call heirarchy, all constructors come here, and `pathValidator` has no setters, it's 100% sure that at this point, pathValidator is null.
- Rajat Khandelwal
On Aug. 4, 2015, 8:18 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 8:18 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 s]
> [INFO] Lens ............................................... SUCCESS [ 3.106 s]
> [INFO] Lens API ........................................... SUCCESS [ 25.443 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.055 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.572 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 s]
> [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 s]
> [INFO] Lens Server ........................................ SUCCESS [05:05 min]
> [INFO] Lens client ........................................ SUCCESS [ 34.200 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:03 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.993 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.751 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:13 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.198 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:30 min
> [INFO] Finished at: 2015-08-04T20:07:56+05:30
> [INFO] Final Memory: 132M/375M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 6, 2015, 12:41 p.m.)
Review request for lens.
Changes
-------
New rebased patch.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 51c4baf
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 1487c5a
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 49fab8a
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 4143525
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.972 s]
[INFO] Lens ............................................... SUCCESS [ 2.726 s]
[INFO] Lens API ........................................... SUCCESS [ 29.047 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.110 s]
[INFO] Lens Cube .......................................... SUCCESS [05:23 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.579 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.963 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:39 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.261 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.172 s]
[INFO] Lens Server ........................................ SUCCESS [05:44 min]
[INFO] Lens client ........................................ SUCCESS [ 44.869 s]
[INFO] Lens CLI ........................................... SUCCESS [02:10 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.891 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.484 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:35 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.117 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.351 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 21:18 min
[INFO] Finished at: 2015-08-06T17:45:57+05:30
[INFO] Final Memory: 133M/405M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 5, 2015, 7:44 a.m.)
Review request for lens.
Changes
-------
Added build results.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.313 s]
[INFO] Lens ............................................... SUCCESS [ 5.414 s]
[INFO] Lens API ........................................... SUCCESS [ 28.675 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 19.036 s]
[INFO] Lens Cube .......................................... SUCCESS [05:03 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.007 s]
[INFO] Lens Query Library ................................. SUCCESS [ 13.939 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 32.631 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 15.750 s]
[INFO] Lens Server ........................................ SUCCESS [05:36 min]
[INFO] Lens client ........................................ SUCCESS [ 38.828 s]
[INFO] Lens CLI ........................................... SUCCESS [02:08 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.725 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.639 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:37 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.107 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.747 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:27 min
[INFO] Finished at: 2015-08-05T12:55:25+05:30
[INFO] Final Memory: 132M/403M
[INFO] -----------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 4:58 p.m.)
Review request for lens.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 s]
[INFO] Lens ............................................... SUCCESS [ 3.106 s]
[INFO] Lens API ........................................... SUCCESS [ 25.443 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.055 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.572 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 s]
[INFO] Lens Server ........................................ SUCCESS [05:05 min]
[INFO] Lens client ........................................ SUCCESS [ 34.200 s]
[INFO] Lens CLI ........................................... SUCCESS [02:03 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.993 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.751 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:13 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.198 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:30 min
[INFO] Finished at: 2015-08-04T20:07:56+05:30
[INFO] Final Memory: 132M/375M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 4:33 p.m.)
Review request for lens.
Changes
-------
New review comments.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 s]
[INFO] Lens ............................................... SUCCESS [ 3.106 s]
[INFO] Lens API ........................................... SUCCESS [ 25.443 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.055 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.572 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 s]
[INFO] Lens Server ........................................ SUCCESS [05:05 min]
[INFO] Lens client ........................................ SUCCESS [ 34.200 s]
[INFO] Lens CLI ........................................... SUCCESS [02:03 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.993 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.751 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:13 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.198 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:30 min
[INFO] Finished at: 2015-08-04T20:07:56+05:30
[INFO] Final Memory: 132M/375M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 2:48 p.m.)
Review request for lens.
Changes
-------
Added build results.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.077 s]
[INFO] Lens ............................................... SUCCESS [ 3.106 s]
[INFO] Lens API ........................................... SUCCESS [ 25.443 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.068 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.055 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.572 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.434 s]
[INFO] Lens Elastic Search Driver ......................... SUCCESS [ 16.330 s]
[INFO] Lens Server ........................................ SUCCESS [05:05 min]
[INFO] Lens client ........................................ SUCCESS [ 34.200 s]
[INFO] Lens CLI ........................................... SUCCESS [02:03 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.993 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.751 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:13 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.092 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.198 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:30 min
[INFO] Finished at: 2015-08-04T20:07:56+05:30
[INFO] Final Memory: 132M/375M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 4, 2015, 2:47 p.m.)
Review request for lens.
Changes
-------
Implemented new review comments.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
[INFO] Lens ............................................... SUCCESS [ 2.926 s]
[INFO] Lens API ........................................... SUCCESS [ 23.384 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
[INFO] Lens Server ........................................ SUCCESS [05:02 min]
[INFO] Lens client ........................................ SUCCESS [ 36.456 s]
[INFO] Lens CLI ........................................... SUCCESS [02:07 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:19 min
[INFO] Finished at: 2015-08-01T11:23:10+05:30
[INFO] Final Memory: 131M/421M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On Aug. 4, 2015, 6:53 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 188
> > <https://reviews.apache.org/r/36178/diff/10-11/?file=1024381#file1024381line188>
> >
> > Instead of creating a new one, let's use `new PathValidator(getClient().getConnection().getParams().getSessionConf())` inside `setClient` and store the variable.
> >
> > Now it sounds like path validator would be tied to `LensClient` instance, so it might be better to have the path validator inside lens client. And there, `connectToLensServer` is creating a `LensConnectionParams` instance which can be used for creating LensConf and instantiating PathValidator.
Implemented.
What about the BaseLensService changes ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review94006
-----------------------------------------------------------
On Aug. 4, 2015, 2:47 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 2:47 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review94006
-----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 188)
<https://reviews.apache.org/r/36178/#comment148508>
Instead of creating a new one, let's use `new PathValidator(getClient().getConnection().getParams().getSessionConf())` inside `setClient` and store the variable.
Now it sounds like path validator would be tied to `LensClient` instance, so it might be better to have the path validator inside lens client. And there, `connectToLensServer` is creating a `LensConnectionParams` instance which can be used for creating LensConf and instantiating PathValidator.
- Rajat Khandelwal
On Aug. 1, 2015, 11:46 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 11:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On Aug. 3, 2015, 8:16 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java, line 189
> > <https://reviews.apache.org/r/36178/diff/10-11/?file=1024381#file1024381line189>
> >
> > path validator instance can be cached.
How are we planning to cache it ? Against the conf ?
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93876
-----------------------------------------------------------
On Aug. 1, 2015, 6:16 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 6:16 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On Aug. 3, 2015, 8:16 a.m., Rajat Khandelwal wrote:
> > lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java, line 103
> > <https://reviews.apache.org/r/36178/diff/10-11/?file=1024383#file1024383line103>
> >
> > So for jar/file commands, we can't take `File` argument. Since `File` argument will give filename suggestions on client machine. And the path is supposed to be a valid path accessible from server machine.
Changed back to String paths.
> On Aug. 3, 2015, 8:16 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java, line 195
> > <https://reviews.apache.org/r/36178/diff/10-11/?file=1024379#file1024379line195>
> >
> > We can remove the `specialHandling` flag. It can be designed as a variable which defaults to `:///` and takes value from lens conf if present.
Implemented.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93876
-----------------------------------------------------------
On Aug. 4, 2015, 2:47 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 2:47 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 57c672c
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93876
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java (line 134)
<https://reviews.apache.org/r/36178/#comment148293>
We can remove the `specialHandling` flag. It can be designed as a variable which defaults to `:///` and takes value from lens conf if present.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 189)
<https://reviews.apache.org/r/36178/#comment148294>
path validator instance can be cached.
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java (line 200)
<https://reviews.apache.org/r/36178/#comment148295>
This can use the cached instance of path validator
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java (line 101)
<https://reviews.apache.org/r/36178/#comment148296>
So for jar/file commands, we can't take `File` argument. Since `File` argument will give filename suggestions on client machine. And the path is supposed to be a valid path accessible from server machine.
- Rajat Khandelwal
On Aug. 1, 2015, 11:46 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 11:46 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
> lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 5dd0bfb
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
> [INFO] Lens ............................................... SUCCESS [ 2.926 s]
> [INFO] Lens API ........................................... SUCCESS [ 23.384 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:09 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
> [INFO] Lens Server ........................................ SUCCESS [05:02 min]
> [INFO] Lens client ........................................ SUCCESS [ 36.456 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:19 min
> [INFO] Finished at: 2015-08-01T11:23:10+05:30
> [INFO] Final Memory: 131M/421M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated Aug. 1, 2015, 6:16 a.m.)
Review request for lens.
Changes
-------
New review comments for creating PathValidator with LensConf rather than util class.
@prongs: Need to check if its implemented as planned.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/LensConf.java 1f02431
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java da11069
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 5dd0bfb
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.982 s]
[INFO] Lens ............................................... SUCCESS [ 2.926 s]
[INFO] Lens API ........................................... SUCCESS [ 23.384 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.930 s]
[INFO] Lens Cube .......................................... SUCCESS [05:09 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.053 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.298 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.895 s]
[INFO] Lens Server ........................................ SUCCESS [05:02 min]
[INFO] Lens client ........................................ SUCCESS [ 36.456 s]
[INFO] Lens CLI ........................................... SUCCESS [02:07 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.820 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.816 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.677 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.533 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:19 min
[INFO] Finished at: 2015-08-01T11:23:10+05:30
[INFO] Final Memory: 131M/421M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 29, 2015, 9:21 a.m.)
Review request for lens.
Changes
-------
New review comments.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/util/PathValidator.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestPathValidator.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java ae6d682
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt a28d8a4
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.073 s]
[INFO] Lens ............................................... SUCCESS [ 2.919 s]
[INFO] Lens API ........................................... SUCCESS [ 24.629 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 24.005 s]
[INFO] Lens Cube .......................................... SUCCESS [06:03 min]
[INFO] Lens DB storage .................................... SUCCESS [ 21.249 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.129 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:42 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.475 s]
[INFO] Lens Server ........................................ SUCCESS [05:53 min]
[INFO] Lens client ........................................ SUCCESS [ 43.273 s]
[INFO] Lens CLI ........................................... SUCCESS [02:24 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.744 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.569 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:39 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.106 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.772 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 22:10 min
[INFO] Finished at: 2015-07-29T14:38:55+05:30
[INFO] Final Memory: 130M/400M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 28, 2015, 8:04 a.m.)
Review request for lens.
Changes
-------
New review comments.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt a28d8a4
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.025 s]
[INFO] Lens ............................................... SUCCESS [ 3.273 s]
[INFO] Lens API ........................................... SUCCESS [ 22.153 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.811 s]
[INFO] Lens Cube .......................................... SUCCESS [05:38 min]
[INFO] Lens DB storage .................................... SUCCESS [ 21.700 s]
[INFO] Lens Query Library ................................. SUCCESS [ 18.521 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.994 s]
[INFO] Lens Server ........................................ SUCCESS [05:12 min]
[INFO] Lens client ........................................ SUCCESS [ 35.757 s]
[INFO] Lens CLI ........................................... SUCCESS [02:07 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.207 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.026 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:32 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.085 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.609 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 20:23 min
[INFO] Finished at: 2015-07-28T13:28:25+05:30
[INFO] Final Memory: 130M/396M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
> On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java, line 73
> > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021879#file1021879line73>
> >
> > Is there supposed to be a space somewhere?
No. No space in path.
> On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java, line 110
> > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021879#file1021879line110>
> >
> > `file:/a/b/c` will also match, right?
Yes it will match file:/ and try to check if its present in the URI_SCHEME_MAPPING map. Anything present in the URI_SCHEME_MAPPING map would be a candidate for special handling.
Currently the map only has entry for hdfs, s3 & s3n.
> On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote:
> > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java, line 161
> > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021880#file1021880line161>
> >
> > Please add a third argument to the assert method. Saying that `ith` didn't match.
Done.
> On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote:
> > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java, lines 105-107
> > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021880#file1021880line105>
> >
> > This block is not needed. Exception thrown will automatically fail the test.
Done.
> On July 28, 2015, 6:37 a.m., Rajat Khandelwal wrote:
> > lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java, lines 129-131
> > <https://reviews.apache.org/r/36178/diff/7-8/?file=1021880#file1021880line129>
> >
> > Redundant block
Not revoved - for checked exception.
- Yash
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93247
-----------------------------------------------------------
On July 28, 2015, 8:04 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 8:04 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt a28d8a4
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.025 s]
> [INFO] Lens ............................................... SUCCESS [ 3.273 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.153 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 21.811 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:38 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 21.700 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 18.521 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.994 s]
> [INFO] Lens Server ........................................ SUCCESS [05:12 min]
> [INFO] Lens client ........................................ SUCCESS [ 35.757 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:07 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.207 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 8.026 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:32 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.085 s]
> [INFO] Lens Regression .................................... SUCCESS [ 11.609 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 20:23 min
> [INFO] Finished at: 2015-07-28T13:28:25+05:30
> [INFO] Final Memory: 130M/396M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review93247
-----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java (line 73)
<https://reviews.apache.org/r/36178/#comment147587>
Is there supposed to be a space somewhere?
lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java (line 108)
<https://reviews.apache.org/r/36178/#comment147589>
`file:/a/b/c` will also match, right?
lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java (lines 86 - 88)
<https://reviews.apache.org/r/36178/#comment147590>
This block is not needed. Exception thrown will automatically fail the test.
lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java (lines 100 - 102)
<https://reviews.apache.org/r/36178/#comment147591>
Redundant block
lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java (line 132)
<https://reviews.apache.org/r/36178/#comment147592>
Please add a third argument to the assert method. Saying that `ith` didn't match.
- Rajat Khandelwal
On July 28, 2015, 1:26 a.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 28, 2015, 1:26 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt a28d8a4
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.939 s]
> [INFO] Lens ............................................... SUCCESS [ 2.711 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.300 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 23.875 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:27 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 20.550 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 15.160 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.568 s]
> [INFO] Lens Server ........................................ SUCCESS [04:56 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.044 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:06 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.571 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 9.236 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.492 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.130 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 19:27 min
> [INFO] Finished at: 2015-07-28T01:21:57+05:30
> [INFO] Final Memory: 130M/382M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 27, 2015, 7:56 p.m.)
Review request for lens.
Changes
-------
New review comments.
Applies cleanly post - LENS-698
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java c059f30
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java ae04b3f
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 1316257
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt a28d8a4
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 1.939 s]
[INFO] Lens ............................................... SUCCESS [ 2.711 s]
[INFO] Lens API ........................................... SUCCESS [ 22.300 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 23.875 s]
[INFO] Lens Cube .......................................... SUCCESS [05:27 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.550 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.160 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.568 s]
[INFO] Lens Server ........................................ SUCCESS [04:56 min]
[INFO] Lens client ........................................ SUCCESS [ 37.044 s]
[INFO] Lens CLI ........................................... SUCCESS [02:06 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.571 s]
[INFO] Lens Distribution .................................. SUCCESS [ 9.236 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:15 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.492 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.130 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 19:27 min
[INFO] Finished at: 2015-07-28T01:21:57+05:30
[INFO] Final Memory: 130M/382M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 25, 2015, 1:08 p.m.)
Review request for lens.
Changes
-------
Implemented review comments.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
lens-api/src/test/java/org/apache/lens/api/TestApiUtilityMethods.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 319077a
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 5e0f24a
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 63f2b3f
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.260 s]
[INFO] Lens ............................................... SUCCESS [ 2.762 s]
[INFO] Lens API ........................................... SUCCESS [ 23.013 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.134 s]
[INFO] Lens Cube .......................................... SUCCESS [03:53 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.727 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.522 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:30 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.807 s]
[INFO] Lens Server ........................................ SUCCESS [05:00 min]
[INFO] Lens client ........................................ SUCCESS [ 37.785 s]
[INFO] Lens CLI ........................................... SUCCESS [02:04 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.077 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.065 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.631 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.392 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:57 min
[INFO] Finished at: 2015-07-25T18:33:51+05:30
[INFO] Final Memory: 130M/389M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/#review92882
-----------------------------------------------------------
Ship it!
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java (lines 42 - 56)
<https://reviews.apache.org/r/36178/#comment147145>
One more small change, if we static import the method of ApiUtilityMethods, it might minimize the diff at multiple places.
- Rajat Khandelwal
On July 22, 2015, 7:59 p.m., Yash Sharma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36178/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 7:59 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-634
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added changes for file name suggestions on Tab. Changed String file paths to File.
>
>
> https://issues.apache.org/jira/browse/LENS-634
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
> lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
> lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
> lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
> src/site/apt/user/cli.apt 63f2b3f
>
> Diff: https://reviews.apache.org/r/36178/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 s]
> [INFO] Lens ............................................... SUCCESS [ 10.092 s]
> [INFO] Lens API ........................................... SUCCESS [ 22.157 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 s]
> [INFO] Lens Cube .......................................... SUCCESS [03:36 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 19.628 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 14.736 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 s]
> [INFO] Lens Server ........................................ SUCCESS [04:49 min]
> [INFO] Lens client ........................................ SUCCESS [ 37.127 s]
> [INFO] Lens CLI ........................................... SUCCESS [02:43 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 9.946 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 7.965 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
> [INFO] Lens Regression .................................... SUCCESS [ 12.781 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:21 min
> [INFO] Finished at: 2015-07-22T19:27:26+05:30
> [INFO] Final Memory: 130M/395M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Yash Sharma
>
>
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 22, 2015, 2:29 p.m.)
Review request for lens.
Changes
-------
Implemented review comments.
Bugs: LENS-634
https://issues.apache.org/jira/browse/LENS-634
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/util/ApiUtilityMethods.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java bdfae24
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 5fd80a1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java 5493dba
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java c505680
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java 56e962d
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java fa342c8
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 47d27d0
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 63f2b3f
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.756 s]
[INFO] Lens ............................................... SUCCESS [ 10.092 s]
[INFO] Lens API ........................................... SUCCESS [ 22.157 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 20.357 s]
[INFO] Lens Cube .......................................... SUCCESS [03:36 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.628 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.736 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:31 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.394 s]
[INFO] Lens Server ........................................ SUCCESS [04:49 min]
[INFO] Lens client ........................................ SUCCESS [ 37.127 s]
[INFO] Lens CLI ........................................... SUCCESS [02:43 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.946 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.965 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:24 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.781 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:21 min
[INFO] Finished at: 2015-07-22T19:27:26+05:30
[INFO] Final Memory: 130M/395M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 19, 2015, 10:40 a.m.)
Review request for lens.
Changes
-------
Complete build with testcases.
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
src/site/apt/user/cli.apt 353c171
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.830 s]
[INFO] Lens ............................................... SUCCESS [ 4.348 s]
[INFO] Lens API ........................................... SUCCESS [ 19.880 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.601 s]
[INFO] Lens Cube .......................................... SUCCESS [03:41 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.195 s]
[INFO] Lens Query Library ................................. SUCCESS [ 13.843 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:38 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 37.845 s]
[INFO] Lens Server ........................................ SUCCESS [05:03 min]
[INFO] Lens client ........................................ SUCCESS [ 36.162 s]
[INFO] Lens CLI ........................................... SUCCESS [02:10 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.574 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.600 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.812 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.166 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:05 min
[INFO] Finished at: 2015-07-19T16:00:17+05:30
[INFO] Final Memory: 130M/428M
[INFO] -----------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 19, 2015, 10:39 a.m.)
Review request for lens.
Changes
-------
Added Bugfix for non-mandatory path parameters.
Using @NonNull for mandatory attributes & manually checking nullability for non-mandatory attributes.
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
src/site/apt/user/cli.apt 353c171
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.135 s]
[INFO] Lens ............................................... SUCCESS [ 2.813 s]
[INFO] Lens API ........................................... SUCCESS [ 20.590 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.734 s]
[INFO] Lens Cube .......................................... SUCCESS [03:42 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.573 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.858 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:37 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.645 s]
[INFO] Lens Server ........................................ SUCCESS [04:54 min]
[INFO] Lens client ........................................ SUCCESS [ 36.606 s]
[INFO] Lens CLI ........................................... SUCCESS [02:11 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.632 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.609 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.390 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:58 min
[INFO] Finished at: 2015-07-17T22:32:49+05:30
[INFO] Final Memory: 126M/393M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 17, 2015, 5:08 p.m.)
Review request for lens.
Changes
-------
Identified bug with hdfs:// prefix paths. Merged changes in patch.
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java a5033fe
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 715347f
src/site/apt/user/cli.apt 353c171
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.135 s]
[INFO] Lens ............................................... SUCCESS [ 2.813 s]
[INFO] Lens API ........................................... SUCCESS [ 20.590 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 22.734 s]
[INFO] Lens Cube .......................................... SUCCESS [03:42 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.573 s]
[INFO] Lens Query Library ................................. SUCCESS [ 15.858 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:37 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 36.645 s]
[INFO] Lens Server ........................................ SUCCESS [04:54 min]
[INFO] Lens client ........................................ SUCCESS [ 36.606 s]
[INFO] Lens CLI ........................................... SUCCESS [02:11 min]
[INFO] Lens Examples ...................................... SUCCESS [ 10.632 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.609 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:21 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 2.952 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.390 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:58 min
[INFO] Finished at: 2015-07-17T22:32:49+05:30
[INFO] Final Memory: 126M/393M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 15, 2015, 5:33 p.m.)
Review request for lens.
Changes
-------
Implemented review comments
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCRUDCommand.java 9cb7d69
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a479c14
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java 92687c3
src/site/apt/user/cli.apt 353c171
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
New build results-
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
[INFO] Lens ............................................... SUCCESS [ 2.842 s]
[INFO] Lens API ........................................... SUCCESS [ 21.035 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.545 s]
[INFO] Lens Cube .......................................... SUCCESS [03:04 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.023 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.263 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:28 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.581 s]
[INFO] Lens Server ........................................ SUCCESS [05:10 min]
[INFO] Lens client ........................................ SUCCESS [ 36.137 s]
[INFO] Lens CLI ........................................... SUCCESS [02:06 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.193 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.860 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.114 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.437 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:15 min
[INFO] Finished at: 2015-07-05T00:12:45+05:30
[INFO] Final Memory: 125M/375M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 4, 2015, 6:48 p.m.)
Review request for lens.
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
New build results-
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.460 s]
[INFO] Lens ............................................... SUCCESS [ 2.842 s]
[INFO] Lens API ........................................... SUCCESS [ 21.035 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.545 s]
[INFO] Lens Cube .......................................... SUCCESS [03:04 min]
[INFO] Lens DB storage .................................... SUCCESS [ 19.023 s]
[INFO] Lens Query Library ................................. SUCCESS [ 14.263 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:28 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.581 s]
[INFO] Lens Server ........................................ SUCCESS [05:10 min]
[INFO] Lens client ........................................ SUCCESS [ 36.137 s]
[INFO] Lens CLI ........................................... SUCCESS [02:06 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.193 s]
[INFO] Lens Distribution .................................. SUCCESS [ 7.860 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:19 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.114 s]
[INFO] Lens Regression .................................... SUCCESS [ 12.437 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:15 min
[INFO] Finished at: 2015-07-05T00:12:45+05:30
[INFO] Final Memory: 125M/375M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 4, 2015, 6:25 p.m.)
Review request for lens.
Changes
-------
Implemented review comments.
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs (updated)
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseLensCommand.java 74b4e91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/main/java/org/apache/lens/cli/commands/LensCubeCommands.java 6ba702f
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionCommands.java de022c1
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDimensionTableCommands.java 6a93393
lens-cli/src/main/java/org/apache/lens/cli/commands/LensFactCommands.java bdb9c38
lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java c48fabd
lens-cli/src/main/java/org/apache/lens/cli/commands/LensStorageCommands.java 928120a
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 73661e1
lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java b6f96e6
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java a22862e
lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java a87d0b7
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 13bfbd2
lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java 73f3a78
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 46e28a9
lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 3a04ec6
Diff: https://reviews.apache.org/r/36178/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.076 s]
[INFO] Lens ............................................... SUCCESS [ 2.687 s]
[INFO] Lens API ........................................... SUCCESS [ 19.435 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.664 s]
[INFO] Lens Cube .......................................... SUCCESS [03:15 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.368 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.793 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.684 s]
[INFO] Lens Server ........................................ SUCCESS [05:16 min]
[INFO] Lens client ........................................ SUCCESS [ 39.897 s]
[INFO] Lens CLI ........................................... SUCCESS [02:14 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.767 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.144 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:16 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.218 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.612 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:46 min
[INFO] Finished at: 2015-07-04T16:52:09+05:30
[INFO] Final Memory: 125M/401M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma
Re: Review Request 36178: LENS-634 : File name suggestions in cli
when path is expected
Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36178/
-----------------------------------------------------------
(Updated July 4, 2015, 11:22 a.m.)
Review request for lens.
Changes
-------
Updated build results.
Repository: lens
Description
-------
Added changes for file name suggestions on Tab. Changed String file paths to File.
https://issues.apache.org/jira/browse/LENS-634
Diffs
-----
lens-cli/src/main/java/org/apache/lens/cli/commands/LensConnectionCommands.java 8b4face
lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 7503221
Diff: https://reviews.apache.org/r/36178/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.076 s]
[INFO] Lens ............................................... SUCCESS [ 2.687 s]
[INFO] Lens API ........................................... SUCCESS [ 19.435 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 21.664 s]
[INFO] Lens Cube .......................................... SUCCESS [03:15 min]
[INFO] Lens DB storage .................................... SUCCESS [ 20.368 s]
[INFO] Lens Query Library ................................. SUCCESS [ 16.793 s]
[INFO] Lens Hive Driver ................................... SUCCESS [02:33 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [ 33.684 s]
[INFO] Lens Server ........................................ SUCCESS [05:16 min]
[INFO] Lens client ........................................ SUCCESS [ 39.897 s]
[INFO] Lens CLI ........................................... SUCCESS [02:14 min]
[INFO] Lens Examples ...................................... SUCCESS [ 9.767 s]
[INFO] Lens Distribution .................................. SUCCESS [ 8.144 s]
[INFO] Lens ML Lib ........................................ SUCCESS [01:16 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.218 s]
[INFO] Lens Regression .................................... SUCCESS [ 11.612 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:46 min
[INFO] Finished at: 2015-07-04T16:52:09+05:30
[INFO] Final Memory: 125M/401M
[INFO] ------------------------------------------------------------------------
Thanks,
Yash Sharma