You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Alexis Midon (JIRA)" <ji...@apache.org> on 2008/12/10 21:16:44 UTC
[jira] Created: (ODE-459) SoapExternalService#writeHeader
myRoleMessionId passed by coincidence
SoapExternalService#writeHeader myRoleMessionId passed by coincidence
---------------------------------------------------------------------
Key: ODE-459
URL: https://issues.apache.org/jira/browse/ODE-459
Project: ODE
Issue Type: Improvement
Reporter: Alexis Midon
In SoapExternalService#writeHeader, PartnerRoleMessageExchange#getMyRoleEndpointReference is converted into a WSAEndpoint.
The myRoleSessionId is then assigned to this WSAEndpoint reference.
The issue is that the WSAEndpoint reference is never set on the odeMex.
This is a code smell: the myRoleSessionId is passed around only because odeMex.getMyRoleEndpointReference() is a WSAendpoint instance
and that org.apache.ode.bpel.epr.EndpointFactory.convertToWSA() returns "this" in that case.
So the code relies on the fact that odeMex.getMyRoleEndpointReference() will always be a WSAEndpoint instance.
If it's a valid assumption then the call to EndpointFactory#convertToWSA is unnecessary and could be removed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ODE-459) SoapExternalService#writeHeader
myRoleMessionId passed by coincidence
Posted by "Tammo van Lessen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tammo van Lessen updated ODE-459:
---------------------------------
Fix Version/s: 1.3.5
> SoapExternalService#writeHeader myRoleMessionId passed by coincidence
> ---------------------------------------------------------------------
>
> Key: ODE-459
> URL: https://issues.apache.org/jira/browse/ODE-459
> Project: ODE
> Issue Type: Improvement
> Reporter: Alexis Midon
> Fix For: 1.3.5
>
>
> In SoapExternalService#writeHeader, PartnerRoleMessageExchange#getMyRoleEndpointReference is converted into a WSAEndpoint.
> The myRoleSessionId is then assigned to this WSAEndpoint reference.
> The issue is that the WSAEndpoint reference is never set on the odeMex.
> This is a code smell: the myRoleSessionId is passed around only because odeMex.getMyRoleEndpointReference() is a WSAendpoint instance
> and that org.apache.ode.bpel.epr.EndpointFactory.convertToWSA() returns "this" in that case.
> So the code relies on the fact that odeMex.getMyRoleEndpointReference() will always be a WSAEndpoint instance.
> If it's a valid assumption then the call to EndpointFactory#convertToWSA is unnecessary and could be removed.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira