You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <se...@apache.org> on 2017/12/03 20:09:00 UTC
Re: Review Request 62590: WIP: Update to Thrift 0.10.0
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62590/
-----------------------------------------------------------
(Updated Dec. 3, 2017, 9:09 p.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Use the Thrift binary bootstrapped by Pants also for the Java build.
Repository: aurora
Description (updated)
-------
Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
Included changes:
* Update to the latest pants version. This was necesary to make `./pants gen` working. Unfortunately this breaks a few things. For details see https://reviews.apache.org/r/63750/
* The Java `hashcode` option has been removed as it is now the default.
Diffs (updated)
-----
3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a
build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689
build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529
build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6
build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618
build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
build.gradle af119910e84c48f75f2573ababcfa287c3b986fc
buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67
pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
Diff: https://reviews.apache.org/r/62590/diff/2/
Changes: https://reviews.apache.org/r/62590/diff/1-2/
Testing (updated)
-------
./build-support/jenkins/build.sh
Thanks,
Stephan Erb
Re: Review Request 62590: WIP: Update to Thrift 0.10.0
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62590/#review192648
-----------------------------------------------------------
Master (89338dd) is red with this patch.
./build-support/jenkins/build.sh
20:23:58 00:00 [setup]
20:23:58 00:00 [parse]
Executing tasks in goals: gen -> pyprep -> test
20:23:58 00:00 [gen]
20:23:58 00:00 [thrift-py]
20:23:58 00:00 [cache]
No cached artifacts for 1 target.
Invalidated 1 target..
20:23:58 00:00 [pyprep]
20:23:58 00:00 [interpreter]
20:24:02 00:04 [requirements]
20:24:02 00:04 [cache]
No cached artifacts for 34 targets.
Invalidated 34 targets.**** Failed to install pykerberos-1.1.14 (caused by: NonZeroExit("received exit code 1 during execution of `[u'/usr/bin/python2.7', '-', 'bdist_wheel', '--dist-dir=/tmp/tmpVbU5Nf']` while trying to execute `[u'/usr/bin/python2.7', '-', 'bdist_wheel', '--dist-dir=/tmp/tmpVbU5Nf']`",)
):
stdout:
running bdist_wheel
running build
running build_ext
building 'kerberos' extension
creating build
creating build/temp.linux-x86_64-2.7
creating build/temp.linux-x86_64-2.7/src
x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -I/usr/include/python2.7 -c src/kerberos.c -o build/temp.linux-x86_64-2.7/src/kerberos.o
stderr:
In file included from src/kerberos.c:19:0:
src/kerberosbasic.h:17:27: fatal error: gssapi/gssapi.h: No such file or directory
compilation terminated.
error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
Waiting for background workers to finish.
20:24:21 00:23 [complete]
FAILURE
Exception caught: (<class 'pex.resolver.Untranslateable'>)
Exception message: Package SourcePackage(u'file:///home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/resolved_requirements/CPython-2.7.12/pykerberos-1.1.14.tar.gz') is not translateable by ChainedTranslator(WheelTranslator, EggTranslator, SourceTranslator)
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 3, 2017, 12:09 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62590/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2017, 12:09 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Update to Thrift 0.10.0 (https://github.com/apache/thrift/blob/master/CHANGES)
>
> Included changes:
>
> * Update to the latest pants version. This was necesary to make `./pants gen` working. Unfortunately this breaks a few things. For details see https://reviews.apache.org/r/63750/
> * The Java `hashcode` option has been removed as it is now the default.
>
>
> Diffs
> -----
>
> 3rdparty/python/requirements.txt 155930dc6b808fb2f573f427a4508e388ee04b5a
> build-support/packer/build.sh 85444125abc0c7e600a09933411e57c0d74051ac
> build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 77c966caa3d1f644241bcc2b1968bc9306c56689
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch 42300b43a8f72e45c96b975e5d3a6a7bd0283529
> build-support/thrift/AURORA-1727.lib.py.setup.py.patch 11c7b13341e156f3686511cb40ab13c1256203a6
> build-support/thrift/BUILD ab19f1f68682d88f731a463c15591e45a317e760
> build-support/thrift/Makefile f440b610afe321af663e393a29eebda7af7bd7a8
> build-support/thrift/prepare_binary.sh 4ad997bf039294f7940b93a76ebf014689f8f618
> build-support/thrift/thriftw c8debd07bc9da97fb58db795e67c9ac82cc30bc1
> build.gradle af119910e84c48f75f2573ababcfa287c3b986fc
> buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy fc2bc9082dae2c63aa578c05dc89feb346260a67
> pants.ini 0671d9ab6381e5b9c324dc09a891a639cbfb2ccc
> src/main/python/apache/aurora/executor/BUILD 486230db34a22ea5dd0f68da911c0afb1afbcac0
>
>
> Diff: https://reviews.apache.org/r/62590/diff/2/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
>
>
> Thanks,
>
> Stephan Erb
>
>