You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by lewismc <gi...@git.apache.org> on 2015/08/25 22:49:11 UTC
[GitHub] any23 pull request: Gsoc 2015 Microformats2
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/18
Gsoc 2015 Microformats2
I am initiating this PR on behalf of @nisalanirmana so we can think about closing off the GSoC work for the summer. This PR _should_ represent Microformats2 support for Apache Any23 whilst retaining compatibility for original Microformats support.
We can discuss more on the review of the code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nisalanirmana/any23 gsoc_2015
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 5b10339b55ea04e097a960fd722e8553573daccf
Author: nisalanirmana <ni...@gmail.com>
Date: 2015-06-21T18:39:17Z
added HAdr and HGeo Extractors support
commit ff816027510f731f3e3f6a3c410feb5c48ffd972
Author: Nisala Nirmana <ni...@gmail.com>
Date: 2015-06-28T17:03:29Z
changes according to mentor michele feedback
commit 1616c17cb6497bcdf7947ee1048027f1b6d83a9f
Author: Nisala Nirmana <ni...@gmail.com>
Date: 2015-07-05T20:20:42Z
added extractors HRecipe and HItem
commit cc0dfbe8127a00fa712c7d2df6785a73c290feae
Author: Nisala <ni...@gmail.com>
Date: 2015-07-19T19:42:27Z
adding HEvent and HProduct Extractors
commit 817029a862a2beeec06c30a4194963c3efb331d3
Author: Nisala <ni...@gmail.com>
Date: 2015-07-19T19:49:21Z
correction to comments
commit 0008c7c770c8626b766da24522d9e12a8dc97215
Author: Nisala <ni...@gmail.com>
Date: 2015-07-19T19:52:59Z
author correction
commit 417b71a757ecb444a98cebeb25f48faa1c27524f
Author: Nisala <ni...@gmail.com>
Date: 2015-08-23T16:09:34Z
adding HEntry and HResume extractors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: ANY23-207 Implement Microformats2
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/any23/pull/18
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by nisalanirmana <gi...@git.apache.org>.
Github user nisalanirmana commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r38061633
--- Diff: core/src/test/java/org/apache/any23/vocab/RDFSchemaUtilsTest.java ---
@@ -53,7 +53,7 @@ public void testSerializeVocabulariesNTriples() {
*/
@Test
public void testSerializeVocabulariesRDFXML() {
- serializeVocabularies(RDFFormat.RDFXML, 4987); // Effective lines + separators.
+ serializeVocabularies(RDFFormat.RDFXML, 5252); // Effective lines + separators. //4992
--- End diff --
I have now removed the comment. I was not sure about reason behind this test failure at that time, so added a comment for the future reference, later understood that this is due to changes related to added vocabularies by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-137967921
@nisalanirmana is this PR completed now based on our discussion over on the GSoC wiki page? If it is then I can get this merged in to master branch. Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r37917661
--- Diff: core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractor.java ---
@@ -0,0 +1,85 @@
+package org.apache.any23.extractor.html.microformats2;
--- End diff --
ALv2.0 license header required
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: ANY23-207 Implement Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-139149386
OK folks I am going to go ahead and merge this issue and associate it with https://issues.apache.org/jira/browse/ANY23-207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-137988055
Hi Renato to be honest I didn't event notice it.
I think generally speaking it probably is Not encouraged as we all share
the code. I am not fussed either way. :)
On Saturday, September 5, 2015, Renato Marroquin <no...@github.com>
wrote:
> Hey @lewismc <https://github.com/lewismc> I am talking about the @author
> <https://github.com/author> tag, is that encouraged to be used once code
> has been "donated" to the ASF?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/any23/pull/18#issuecomment-137987959>.
>
--
*Lewis*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r38061472
--- Diff: core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractorFactory.java ---
@@ -0,0 +1,40 @@
+package org.apache.any23.extractor.html.microformats2;
--- End diff --
Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r37917900
--- Diff: core/src/test/java/org/apache/any23/vocab/RDFSchemaUtilsTest.java ---
@@ -53,7 +53,7 @@ public void testSerializeVocabulariesNTriples() {
*/
@Test
public void testSerializeVocabulariesRDFXML() {
- serializeVocabularies(RDFFormat.RDFXML, 4987); // Effective lines + separators.
+ serializeVocabularies(RDFFormat.RDFXML, 5252); // Effective lines + separators. //4992
--- End diff --
what doe the comment //4992 represent?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r38061468
--- Diff: core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractor.java ---
@@ -0,0 +1,85 @@
+package org.apache.any23.extractor.html.microformats2;
--- End diff --
Thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-136161934
This looks great @nisalanirmana !
Just two comments. Adding comments to the classes would actually help a newcomer like myself understanding better what each class does. I guess that it is almost self-explanatory with names like "HAdrExtractor" I am guessing it extracts addresses right? But that is my point, I shouldn't be guessing ;)
And the other thing, I remember seeing somewhere that all code contributed to ASF was not supposed to have the <author> tag. Maybe @lewismc knows the truth about it.
Great work!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by nisalanirmana <gi...@git.apache.org>.
Github user nisalanirmana commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r38061380
--- Diff: core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractor.java ---
@@ -0,0 +1,85 @@
+package org.apache.any23.extractor.html.microformats2;
--- End diff --
Added :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by nisalanirmana <gi...@git.apache.org>.
Github user nisalanirmana commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r38061391
--- Diff: core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractorFactory.java ---
@@ -0,0 +1,40 @@
+package org.apache.any23.extractor.html.microformats2;
--- End diff --
Added :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by nisalanirmana <gi...@git.apache.org>.
Github user nisalanirmana commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r38061610
--- Diff: core/src/test/java/org/apache/any23/vocab/RDFSchemaUtilsTest.java ---
@@ -43,7 +43,7 @@
*/
@Test
public void testSerializeVocabulariesNTriples() {
- serializeVocabularies(RDFFormat.NTRIPLES, 1918);
+ serializeVocabularies(RDFFormat.NTRIPLES, 2012);//1920
--- End diff --
I have now removed the comment. I was not sure about reason behind this test failure at that time, so added a comment for the future reference, later understood that this is due to changes related to added vocabularies by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-137967938
hey @renato2099 which tag do you mean? ta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by renato2099 <gi...@git.apache.org>.
Github user renato2099 commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-137987959
Hey @lewismc I am talking about the @author tag, is that encouraged to be used once code has been "donated" to the ASF?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r37917869
--- Diff: core/src/test/java/org/apache/any23/vocab/RDFSchemaUtilsTest.java ---
@@ -43,7 +43,7 @@
*/
@Test
public void testSerializeVocabulariesNTriples() {
- serializeVocabularies(RDFFormat.NTRIPLES, 1918);
+ serializeVocabularies(RDFFormat.NTRIPLES, 2012);//1920
--- End diff --
what doe the comment //1920 represent?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] any23 pull request: Gsoc 2015 Microformats2
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r37917681
--- Diff: core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractorFactory.java ---
@@ -0,0 +1,40 @@
+package org.apache.any23.extractor.html.microformats2;
--- End diff --
ALv2.0 license header required
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---