You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/09 09:40:50 UTC

[GitHub] [flink] afedulov commented on a change in pull request #18905: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors

afedulov commented on a change in pull request #18905:
URL: https://github.com/apache/flink/pull/18905#discussion_r822459386



##########
File path: flink-connectors/flink-sql-connector-kafka/pom.xml
##########
@@ -40,6 +40,12 @@ under the License.
 			<groupId>org.apache.flink</groupId>
 			<artifactId>flink-connector-kafka</artifactId>
 			<version>${project.version}</version>
+			<exclusions>
+				<exclusion>
+					<groupId>org.apache.flink</groupId>
+					<artifactId>flink-connector-base</artifactId>

Review comment:
       @zentol without those exclusions, the package is included twice: once shaded, once non-shaded - see the comment from @dmvk https://github.com/apache/flink/pull/18905#issuecomment-1055498107.
   Not sure why this happens.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org