You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/08/07 21:36:05 UTC
[GitHub] [incubator-mxnet] zachgk commented on a change in pull request
#15760: Fix PR #15489 (Dynamic Library Loading Support)
zachgk commented on a change in pull request #15760: Fix PR #15489 (Dynamic Library Loading Support)
URL: https://github.com/apache/incubator-mxnet/pull/15760#discussion_r311772712
##########
File path: Makefile
##########
@@ -576,7 +576,7 @@ lib/libmxnet.a: $(ALLX_DEP)
@mkdir -p $(@D)
ar crv $@ $(filter %.o, $?)
-lib/libmxnet.so: $(ALLX_DEP)
+lib/libmxnet.so: $(ALLX_DEP) sample_lib
Review comment:
If it is not actually a dependency of libmxnet.so, we shouldn't put it here. Can we move it to .PHONY and/or all target instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services