You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "ppkarwasz (via GitHub)" <gi...@apache.org> on 2023/10/02 08:09:54 UTC
[PR] Fix BND module name detection for multi-release jars [logging-parent]
ppkarwasz opened a new pull request, #32:
URL: https://github.com/apache/logging-parent/pull/32
If a dependency is a multi-release JAR with the module descriptor in `META-INF/versions/9/module-info.class`, BND is not able to detect its module name.
We fix the names of the two multi-release JARs in Apache Logging Services (`log4j-api` and `log4j-core`). The same fix should be applied to all multi-release external dependencies in children POMs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BND module name detection for multi-release jars [logging-parent]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy commented on code in PR #32:
URL: https://github.com/apache/logging-parent/pull/32#discussion_r1342418478
##########
src/changelog/.10.x.x/fix_bnd_required_module_names.xml:
##########
@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<entry xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xmlns="http://logging.apache.org/log4j/changelog"
+ xsi:schemaLocation="http://logging.apache.org/log4j/changelog https://logging.apache.org/log4j/changelog-0.1.1.xsd"
+ type="fixed">
+ <author id="github:ppkarwasz"/>
+ <description format="asciidoc">Fix BND module name detection on multi-release jars.</description>
Review Comment:
```suggestion
<description format="asciidoc">Fix BND module name detection on multi-release JARs</description>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix BND module name detection for multi-release jars [logging-parent]
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy merged PR #32:
URL: https://github.com/apache/logging-parent/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org