[jira] [Commented] (TINKERPOP3-711) Use Jackson in JsonMessageSerializerV1d0Test.java

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14566969#comment-14566969 ] 

ASF GitHub Bot commented on TINKERPOP3-711:
-------------------------------------------

GitHub user pluradj opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/68

    TINKERPOP3-711 Use Jackson in JsonMessageSerializerV1d0Test.java

    Removed org.json dependency in pom.xml, made appropriate code adjustments for Jackson, and also made the Test class names consistent with GraphSONMessageSerializer. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pluradj/incubator-tinkerpop 20150531

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #68
    
----
commit 08c1e27a7a2c16a20dd95a7c069aa0d8aa1e2340
Author: Jason Plurad <pl...@users.noreply.github.com>
Date:   2015-06-01T06:06:32Z

    fix for TINKERPOP3-711 Use Jackson in JsonMessageSerializerV1d0Test.java

----


> Use Jackson in JsonMessageSerializerV1d0Test.java
> -------------------------------------------------
>
>                 Key: TINKERPOP3-711
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-711
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: driver
>            Reporter: Jason Plurad
>
> This test is using org.json.* classes for JSON handling. The license for that jar is questionable http://www.json.org/license.html.
> It would be better to use Jackson or Apache wink-json4j.
> I can provide a pull request for this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)