You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/07/01 11:58:52 UTC

[GitHub] [accumulo] ivakegg commented on a change in pull request #1646: fixes #1644: minor compaction retry

ivakegg commented on a change in pull request #1646:
URL: https://github.com/apache/accumulo/pull/1646#discussion_r448313271



##########
File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/MinorCompactor.java
##########
@@ -148,6 +149,13 @@ public CompactionStats call() {
           reportedProblem = true;
         } catch (CompactionCanceledException e) {
           throw new IllegalStateException(e);
+        } catch (Throwable t) {

Review comment:
       Throwable was intentional, but reducing it to an Error would be fine I guess.  My take was if a "checked" exception is thrown down the road that is not actually caught, then the system will end up in the same defunct state.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org