[GitHub] [incubator-iceberg] Fokko commented on a change in pull request #587: Improve docs on converting the Avro schema

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #587: Improve docs on converting the Avro schema
URL: https://github.com/apache/incubator-iceberg/pull/587#discussion_r346164624
 
 

 ##########
 File path: site/docs/api-quickstart.md
 ##########
 @@ -102,13 +102,13 @@ When using the Iceberg API directly, type IDs are required. Conversions from oth
 
 When a table is created, all IDs in the schema are re-assigned to ensure uniqueness.
 
-### Convert a schema from Avro
+### Convert a schema from Apache Avro
 
-To create an Iceberg schema from an existing Avro schema, use converters in `AvroSchemaUtil`:
+To create an Iceberg schema from an existing [Apache Avro schema](https://avro.apache.org/), use converters in `AvroSchemaUtil`:
 
 ```scala
 import org.apache.iceberg.avro.AvroSchemaUtil
-import org.apache.avro.Schema.Parser
+import org.apache.iceberg.shaded.org.apache.avro.Schema.Parser
 
 Review comment:
   I've reverted this line until Iceberg 0.8 gets released.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org