[GitHub] [skywalking] aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket

[GitBox <gi...@apache.org>]

aderm commented on a change in pull request #4353: Optimizing performance reduces es index queries scope by timebucket
URL: https://github.com/apache/skywalking/pull/4353#discussion_r378083903
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/DurationUtils.java
 ##########
 @@ -213,4 +213,36 @@ private DateTime parseToDateTime(Downsampling downsampling, long time) {
         }
         throw new UnexpectedException("Unexpected downsampling: " + downsampling.name());
     }
+
+    public DateTime startTimeBucket2DateTime(Downsampling downsampling, long startTB) {
 
 Review comment:
   Indeed, it maybe faster to convert to long. When the date while loop statement is added, it needs to be converted to the character format of the date.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services