You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/02/12 05:30:34 UTC

[GitHub] [guacamole-server] mather commented on a change in pull request #256: GUACAMOLE-951: Add ability to set KeyboardType for FreeRDP

mather commented on a change in pull request #256: GUACAMOLE-951: Add ability to set KeyboardType for FreeRDP
URL: https://github.com/apache/guacamole-server/pull/256#discussion_r378047164
 
 

 ##########
 File path: src/protocols/rdp/keymaps/ja_jp_qwerty.keymap
 ##########
 @@ -20,6 +20,9 @@
 parent  "base"
 name    "ja-jp-qwerty"
 freerdp "KBD_JAPANESE"
+freerdp_keyboard_type "KBD_TYPE_JAPANESE"
 
 Review comment:
   FreeRDP has default values.
   https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp/core/settings.c#L345-L347
   So, no need to specify if there is no problem for other layouts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services