You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/07 02:32:12 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #18872: Re-enable the linker version scripts for binary distribution

leezu opened a new pull request #18872:
URL: https://github.com/apache/incubator-mxnet/pull/18872


   ## Description ##
   Wasn't ported from Makefile binary distribution build yet, but required to avoid
   
   "According to the ELF lookup rules all symbols in the dynamic symbol table can be
   interposed (unless the visibility of the symbol is restricted). I.e.,definitions
   from other objects can be used. This means that local references cannot be bound
   at linktime. If it is known or intended that the local definition should always
   be used the symbol in the reference must not be exported or the visibility
   mustbe restricted" https://www.akkadia.org/drepper/dsohowto.pdf Section 2.2
   
   Related https://github.com/apache/incubator-mxnet/issues/18855


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #18872: Re-enable the linker version scripts for binary distribution

Posted by GitBox <gi...@apache.org>.
szha merged pull request #18872:
URL: https://github.com/apache/incubator-mxnet/pull/18872


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18872: Re-enable the linker version scripts for binary distribution

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18872:
URL: https://github.com/apache/incubator-mxnet/pull/18872#issuecomment-670287134


   Hey @leezu , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, unix-cpu, miscellaneous, edge, sanity, centos-cpu, clang, windows-gpu, website, unix-gpu, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org