You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Scott Kurz (JIRA)" <de...@tuscany.apache.org> on 2009/01/30 18:10:59 UTC
[jira] Created: (TUSCANY-2799) jmsObject wireFormat always
returning Object[] over service response
jmsObject wireFormat always returning Object[] over service response
--------------------------------------------------------------------
Key: TUSCANY-2799
URL: https://issues.apache.org/jira/browse/TUSCANY-2799
Project: Tuscany
Issue Type: Bug
Components: Java SCA JMS Binding Extension
Reporter: Scott Kurz
I wanted to note the problem before having time to think through all the issues and code points we need to sort through.
To start note that WireFormatJMSObjectServiceInterceptor.invokeResponse() does:
...
Object[] response = {msg.getBody()};
But if my service interface is returning a non-array type like a simple String, it seems more natural to return a single return value rather than an array here.
Not sure where any OASIS specs or discussions of this issue stand at the moment...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2799) jmsObject wireFormat always
returning Object[] over service response
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669912#action_12669912 ]
Simon Laws commented on TUSCANY-2799:
-------------------------------------
Hi
I took a look a the JMS code and pinged Ant offline about it. Consensus is there doesn't seem to be a good reason that the return param is wrapped in an array. I'll have a go a some re factoring to remove this wrapping.
Simon
> jmsObject wireFormat always returning Object[] over service response
> --------------------------------------------------------------------
>
> Key: TUSCANY-2799
> URL: https://issues.apache.org/jira/browse/TUSCANY-2799
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Scott Kurz
>
> I wanted to note the problem before having time to think through all the issues and code points we need to sort through.
> To start note that WireFormatJMSObjectServiceInterceptor.invokeResponse() does:
> ...
> Object[] response = {msg.getBody()};
> But if my service interface is returning a non-array type like a simple String, it seems more natural to return a single return value rather than an array here.
> Not sure where any OASIS specs or discussions of this issue stand at the moment...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TUSCANY-2799) jmsObject wireFormat always
returning Object[] over service response
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Laws reassigned TUSCANY-2799:
-----------------------------------
Assignee: Simon Laws
> jmsObject wireFormat always returning Object[] over service response
> --------------------------------------------------------------------
>
> Key: TUSCANY-2799
> URL: https://issues.apache.org/jira/browse/TUSCANY-2799
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Scott Kurz
> Assignee: Simon Laws
>
> I wanted to note the problem before having time to think through all the issues and code points we need to sort through.
> To start note that WireFormatJMSObjectServiceInterceptor.invokeResponse() does:
> ...
> Object[] response = {msg.getBody()};
> But if my service interface is returning a non-array type like a simple String, it seems more natural to return a single return value rather than an array here.
> Not sure where any OASIS specs or discussions of this issue stand at the moment...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TUSCANY-2799) jmsObject wireFormat always
returning Object[] over service response
Posted by "ant elder (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ant elder resolved TUSCANY-2799.
--------------------------------
Resolution: Fixed
Fix Version/s: Java-SCA-Next
> jmsObject wireFormat always returning Object[] over service response
> --------------------------------------------------------------------
>
> Key: TUSCANY-2799
> URL: https://issues.apache.org/jira/browse/TUSCANY-2799
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Scott Kurz
> Assignee: Simon Laws
> Fix For: Java-SCA-Next
>
>
> I wanted to note the problem before having time to think through all the issues and code points we need to sort through.
> To start note that WireFormatJMSObjectServiceInterceptor.invokeResponse() does:
> ...
> Object[] response = {msg.getBody()};
> But if my service interface is returning a non-array type like a simple String, it seems more natural to return a single return value rather than an array here.
> Not sure where any OASIS specs or discussions of this issue stand at the moment...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2799) jmsObject wireFormat always
returning Object[] over service response
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12671093#action_12671093 ]
Simon Laws commented on TUSCANY-2799:
-------------------------------------
This changed uncovered the need to check for null responses in some places. Change committed to the 1.x branch at revision: 741535
> jmsObject wireFormat always returning Object[] over service response
> --------------------------------------------------------------------
>
> Key: TUSCANY-2799
> URL: https://issues.apache.org/jira/browse/TUSCANY-2799
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Scott Kurz
> Assignee: Simon Laws
>
> I wanted to note the problem before having time to think through all the issues and code points we need to sort through.
> To start note that WireFormatJMSObjectServiceInterceptor.invokeResponse() does:
> ...
> Object[] response = {msg.getBody()};
> But if my service interface is returning a non-array type like a simple String, it seems more natural to return a single return value rather than an array here.
> Not sure where any OASIS specs or discussions of this issue stand at the moment...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2799) jmsObject wireFormat always
returning Object[] over service response
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670846#action_12670846 ]
Simon Laws commented on TUSCANY-2799:
-------------------------------------
I committed a change to the 1.x branch at revision: 741219. Can you take a look and see if this answers your concern.
Simon
> jmsObject wireFormat always returning Object[] over service response
> --------------------------------------------------------------------
>
> Key: TUSCANY-2799
> URL: https://issues.apache.org/jira/browse/TUSCANY-2799
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Scott Kurz
> Assignee: Simon Laws
>
> I wanted to note the problem before having time to think through all the issues and code points we need to sort through.
> To start note that WireFormatJMSObjectServiceInterceptor.invokeResponse() does:
> ...
> Object[] response = {msg.getBody()};
> But if my service interface is returning a non-array type like a simple String, it seems more natural to return a single return value rather than an array here.
> Not sure where any OASIS specs or discussions of this issue stand at the moment...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TUSCANY-2799) jmsObject wireFormat always
returning Object[] over service response
Posted by "Simon Laws (JIRA)" <de...@tuscany.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668958#action_12668958 ]
Simon Laws commented on TUSCANY-2799:
-------------------------------------
Hi
OASIS hasn't said anything about specific wire formats just yet. I did see that a mail on the mail list (http://lists.oasis-open.org/archives/sca-bindings/200812/msg00077.html) making a proposal for a new issue to define explicit wire formats but I don't see that it's turned into an actual issue yet.
I'll look at what's behind Object[].
Simon
> jmsObject wireFormat always returning Object[] over service response
> --------------------------------------------------------------------
>
> Key: TUSCANY-2799
> URL: https://issues.apache.org/jira/browse/TUSCANY-2799
> Project: Tuscany
> Issue Type: Bug
> Components: Java SCA JMS Binding Extension
> Reporter: Scott Kurz
>
> I wanted to note the problem before having time to think through all the issues and code points we need to sort through.
> To start note that WireFormatJMSObjectServiceInterceptor.invokeResponse() does:
> ...
> Object[] response = {msg.getBody()};
> But if my service interface is returning a non-array type like a simple String, it seems more natural to return a single return value rather than an array here.
> Not sure where any OASIS specs or discussions of this issue stand at the moment...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.