You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/03 20:30:50 UTC
[GitHub] [beam] ibzib opened a new pull request #11914: [BEAM-10187] Push release candidate tag to Github.
ibzib opened a new pull request #11914:
URL: https://github.com/apache/beam/pull/11914
R: @TheNeuralBit @amaliujia
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11914: [BEAM-10187] Push release candidate tag to Github.
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434844066
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
-Prelease.releaseVersion=${RELEASE}-RC${RC_NUM} \
-Prelease.useAutomaticVersion=true --info --no-daemon
- echo "Please make sure gradle release succeed: "
- echo "1. release code has been pushed to github repo."
- echo "2. new rc tag has created in github."
+ git push "v${RELEASE}-RC${RC_NUM}"
Review comment:
> When I did this locally there was one more commit on the release-2.22.0 branch changing the version to 2.22.0-SNAPSHOT, so I had to run git push origin release-2.22.0 as well.
I see two commits, one changing it to RC1 and next changing it back to SNAPSHOT. Isn't that just a no-op? https://github.com/apache/beam/commits/release-2.22.0
> Also is it ok to omit the origin?
Origin is the default IIUC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib commented on a change in pull request #11914: [BEAM-10187] Push release candidate tag to Github.
Posted by GitBox <gi...@apache.org>.
ibzib commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434850943
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
-Prelease.releaseVersion=${RELEASE}-RC${RC_NUM} \
-Prelease.useAutomaticVersion=true --info --no-daemon
- echo "Please make sure gradle release succeed: "
- echo "1. release code has been pushed to github repo."
- echo "2. new rc tag has created in github."
+ git push "v${RELEASE}-RC${RC_NUM}"
Review comment:
Ah you're right about both. Fixed, PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #11914: [BEAM-10187] Push release candidate tag to Github.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434840793
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
-Prelease.releaseVersion=${RELEASE}-RC${RC_NUM} \
-Prelease.useAutomaticVersion=true --info --no-daemon
- echo "Please make sure gradle release succeed: "
- echo "1. release code has been pushed to github repo."
- echo "2. new rc tag has created in github."
+ git push "v${RELEASE}-RC${RC_NUM}"
Review comment:
When I did this locally there was one more commit on the `release-2.22.0` branch changing the version to 2.22.0-SNAPSHOT, so I had to run `git push origin release-2.22.0` as well.
Also is it ok to omit the `origin`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ibzib merged pull request #11914: [BEAM-10187] Push release candidate tag to Github.
Posted by GitBox <gi...@apache.org>.
ibzib merged pull request #11914:
URL: https://github.com/apache/beam/pull/11914
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #11914: [BEAM-10187] Push release candidate tag to Github.
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434847753
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
-Prelease.releaseVersion=${RELEASE}-RC${RC_NUM} \
-Prelease.useAutomaticVersion=true --info --no-daemon
- echo "Please make sure gradle release succeed: "
- echo "1. release code has been pushed to github repo."
- echo "2. new rc tag has created in github."
+ git push "v${RELEASE}-RC${RC_NUM}"
Review comment:
> I see two commits, one changing it to RC1 and next changing it back to SNAPSHOT. Isn't that just a no-op? https://github.com/apache/beam/commits/release-2.22.0
Yes but the first one is tagged with v2.22.0-RC1 https://github.com/apache/beam/commits/v2.22.0-RC1. So if you only push the tag it won't actually be a noop.
> Origin is the default IIUC.
`git help push` says `git push ... [<repository> [<refspec>...]]` which I take to mean if you only pass one arg it's interpreted as the `repository`. That does seem to be what happens when I try it:
```
❯ git push release-2.22.0
fatal: 'release-2.22.0' does not appear to be a git repository
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org