You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/03/31 11:32:48 UTC
[GitHub] [superset] codecov[bot] commented on pull request #23491: [WIP] perf(sqla): avoid unnecessary type check on adhoc column
codecov[bot] commented on PR #23491:
URL: https://github.com/apache/superset/pull/23491#issuecomment-1491784999
## [Codecov](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23491](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27c3c45) into [master](https://codecov.io/gh/apache/superset/commit/500d90058f44dcbd4851f9110d9edf5b117fe92c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (500d900) will **decrease** coverage by `11.32%`.
> The diff coverage is `84.44%`.
> :exclamation: Current head 27c3c45 differs from pull request most recent head de0c2bf. Consider uploading reports for the commit de0c2bf to get more accurate results
```diff
@@ Coverage Diff @@
## master #23491 +/- ##
===========================================
- Coverage 67.66% 56.35% -11.32%
===========================================
Files 1914 1914
Lines 73936 73962 +26
Branches 8022 8029 +7
===========================================
- Hits 50028 41680 -8348
- Misses 21864 30236 +8372
- Partials 2044 2046 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| postgres | `?` | |
| presto | `52.66% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `58.96% <100.00%> (-23.39%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `52.62% <16.66%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/components/FiltersBadge/index.tsx](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlcnNCYWRnZS9pbmRleC50c3g=) | `84.61% <0.00%> (-1.33%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/CrossFilters/Vertical.tsx](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nyb3NzRmlsdGVycy9WZXJ0aWNhbC50c3g=) | `10.00% <0.00%> (-1.12%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/CrossFilters/selectors.ts](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0Nyb3NzRmlsdGVycy9zZWxlY3RvcnMudHM=) | `10.00% <0.00%> (ø)` | |
| [...rc/dashboard/components/nativeFilters/selectors.ts](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc2VsZWN0b3JzLnRz) | `57.36% <0.00%> (-0.91%)` | :arrow_down: |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `61.90% <ø> (-14.97%)` | :arrow_down: |
| [...hboard/components/nativeFilters/FilterBar/utils.ts](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL3V0aWxzLnRz) | `68.18% <85.71%> (+8.18%)` | :arrow_up: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `54.07% <92.30%> (+0.76%)` | :arrow_up: |
| [...ilters/FilterBar/FilterControls/FilterControls.tsx](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlckNvbnRyb2xzL0ZpbHRlckNvbnRyb2xzLnRzeA==) | `69.73% <100.00%> (+0.40%)` | :arrow_up: |
| [.../components/nativeFilters/FilterBar/Horizontal.tsx](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0hvcml6b250YWwudHN4) | `96.00% <100.00%> (+0.16%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `91.27% <100.00%> (-0.51%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/superset/pull/23491?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [299 files with indirect coverage changes](https://codecov.io/gh/apache/superset/pull/23491/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org