You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by infil00p <gi...@git.apache.org> on 2016/09/09 17:02:50 UTC
[GitHub] cordova-android pull request #330: Bridge Fixes for Android Jellybean
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/330
Bridge Fixes for Android Jellybean
Updating the Javascript to detect whether we're using Jellybean or not using the userAgent, and pick the right bridge based on the version of Android. This isn't the best solution, but it's good enough until people stop using Jellybean.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/infil00p/cordova-android JellybeanBridge
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/330.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #330
----
commit 556f8252c44fee01d0cd4522971e0772670b4121
Author: Joe Bowser <bo...@apache.org>
Date: 2016-09-08T22:29:00Z
CB-11828: Switching default bridge back to ONLINE_BRIDGE
commit 49cf8ae78a14346a8a97cd7694d2d43cf73a6bad
Author: Joe Bowser <bo...@apache.org>
Date: 2016-09-09T17:01:04Z
CB-11828: Adding dirty userAgent checking to see if we're running Jellybean or not for bridge modes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #330: Bridge Fixes for Android Jellybean
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/330
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #330: Bridge Fixes for Android Jellybean
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/330
@dpogue Again, it would be in the userAgent, but I'm fine with leaving ONLINE_BRIDGE as the default for Crosswalk, since we also force Crosswalk to use prompt for the jsToNative bridge even though it could probably use addJavascriptInterface without everything burning down.
Closing PR for now, I merged this due to priority.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #330: Bridge Fixes for Android Jellybean
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/330
## [Current coverage](https://codecov.io/gh/apache/cordova-android/pull/330?src=pr) is 33.78% (diff: 100%)
> Merging [#330](https://codecov.io/gh/apache/cordova-android/pull/330?src=pr) into [master](https://codecov.io/gh/apache/cordova-android/branch/master?src=pr) will not change coverage
```diff
@@ master #330 diff @@
==========================================
Files 11 11
Lines 965 965
Methods 197 197
Messages 0 0
Branches 157 157
==========================================
Hits 326 326
Misses 639 639
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last update [3a33f4c...49cf8ae](https://codecov.io/gh/apache/cordova-android/compare/3a33f4c0a62291ed4faf444cd4525952f90a0b57...49cf8ae78a14346a8a97cd7694d2d43cf73a6bad?src=pr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #330: Bridge Fixes for Android Jellybean
Posted by dpogue <gi...@git.apache.org>.
Github user dpogue commented on the issue:
https://github.com/apache/cordova-android/pull/330
Is there a good way to check if we're using the system webview when making this change? I suspect Crosswalk could use the evaluateJavascript bridge even on Jellybean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org