You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by uc...@apache.org on 2015/11/02 09:11:27 UTC

flink git commit: [FLINK-2912] [web-runtime-web] Add comment to StaticFileServerHandler

Repository: flink
Updated Branches:
  refs/heads/master 0845529ca -> 458009da8


[FLINK-2912] [web-runtime-web] Add comment to StaticFileServerHandler


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/458009da
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/458009da
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/458009da

Branch: refs/heads/master
Commit: 458009da805883b433241a992f67feb76cc3bab4
Parents: 0845529
Author: Ufuk Celebi <uc...@apache.org>
Authored: Mon Nov 2 09:09:44 2015 +0100
Committer: Ufuk Celebi <uc...@apache.org>
Committed: Mon Nov 2 09:09:44 2015 +0100

----------------------------------------------------------------------
 .../flink/runtime/webmonitor/files/StaticFileServerHandler.java     | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/458009da/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
index df330fd..5e56295 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
@@ -246,6 +246,7 @@ public class StaticFileServerHandler extends SimpleChannelInboundHandler<Routed>
 			logger.debug("Responding with file '" + file.getAbsolutePath() + '\'');
 		}
 
+		// Don't need to close this manually. Netty's DefaultFileRegion will take care of it.
 		final RandomAccessFile raf;
 		try {
 			raf = new RandomAccessFile(file, "r");