[GitHub] [hadoop] nandakumar131 commented on issue #567: HDDS-1196. Add a ReplicationStartTimer class.

[GitBox <gi...@apache.org>]

nandakumar131 commented on issue #567: HDDS-1196. Add a ReplicationStartTimer class.
URL: https://github.com/apache/hadoop/pull/567#issuecomment-470603157
 
 
   Adding `ReplicationBeginTimer` handler should be done outside `SCMChillModeManager`. An event producer doesn't need to know about the event consumers. We can add the handler in `StorageContainerManager`, that's where we add all the handlers.
   
   We don't have to check `chillModeEnabled` inside `ReplicationBeginTimer`, that check is already done in `SCMChillModeManager`.
   
   New Thread creation in `ReplicationBeginTimer` can be replaced with `CompletableFuture.runAsync(this::run)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org