[jira] [Commented] (YETUS-1202) plug-ins cannot use filefilter to build lists of files

["Allen Wittenauer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-1202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613597#comment-17613597 ] 

Allen Wittenauer commented on YETUS-1202:
-----------------------------------------

Since there is pressure to get a release out, I'm going to take the minimal approach.  I'll file subsequent JIRAs where more work really should be done to clean it up.

> plug-ins cannot use filefilter to build lists of files
> ------------------------------------------------------
>
>                 Key: YETUS-1202
>                 URL: https://issues.apache.org/jira/browse/YETUS-1202
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Precommit
>    Affects Versions: 0.14.0
>            Reporter: Allen Wittenauer
>            Assignee: Allen Wittenauer
>            Priority: Blocker
>             Fix For: 0.15.0
>
>
> The core problem is that in patch mode, CHANGED_FILES is based upon the patch file without any extra processing.  All files that are touched in some way are sent to filefilter in order to trigger the appropriate tests.  The problem comes in that files that are added may also be excluded in the same patch.  The software won't be able to update CHANGED_FILES until the patch is applied fully applied. At that point, any 'local' file list copy will be incorrect.
> Plug-ins that absolutely, positively must keep track of files here must ALSO filter their list against EXCLUDE_PATHS.  But realistically, it would better if no such file list was kept and only used CHANGED_FILES directly.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)