[GitHub] [flink] akalash commented on a change in pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.

[GitBox <gi...@apache.org>]

akalash commented on a change in pull request #17573:
URL: https://github.com/apache/flink/pull/17573#discussion_r737621857



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java
##########
@@ -298,7 +302,7 @@ private BufferBuilder appendUnicastDataForRecordContinuation(
         // with a complete record.
         // !! The next two lines can not change order.
         final int partialRecordBytes = buffer.appendAndCommit(remainingRecordBytes);
-        addToSubpartition(buffer, targetSubpartition, partialRecordBytes);
+        addToSubpartition(buffer, targetSubpartition, partialRecordBytes, 0);

Review comment:
       in this case, it doesn't matter because both of them will work the same since we anyway never split the partial record. But as I can see now, perhaps you are right and `partialRecordBytes` looks more intuitive here
   I have the test coverage for this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org