[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1540: JAMES-3905 LDAP should allow per user base DN

["quantranhong1999 (via GitHub)" <gi...@apache.org>]

quantranhong1999 commented on code in PR #1540:
URL: https://github.com/apache/james-project/pull/1540#discussion_r1177310689


##########
server/data/data-ldap/src/main/java/org/apache/james/user/ldap/LdapRepositoryConfiguration.java:
##########
@@ -250,12 +275,17 @@ public static LdapRepositoryConfiguration from(HierarchicalConfiguration<Immutab
      * The administrator is allowed to log in as other users
      */
     private final Optional<Username> administratorId;
+
     private final boolean trustAllCerts;
 
+    private final ImmutableMap<Domain, String> perDomainBaseDN;
+
     private LdapRepositoryConfiguration(String ldapHost, String principal, String credentials, String userBase, String userIdAttribute,
                                         String userObjectClass, int connectionTimeout, int readTimeout,
                                         boolean supportsVirtualHosting, int poolSize, ReadOnlyLDAPGroupRestriction restriction, String filter,
-                                        Optional<String> administratorId, boolean trustAllCerts) throws ConfigurationException {
+

Review Comment:
   ```suggestion
   ```
   
   redundant line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org