You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/20 19:17:32 UTC
[GitHub] [kafka] mihasya opened a new pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class
mihasya opened a new pull request #10569:
URL: https://github.com/apache/kafka/pull/10569
This allows Jackson and other serialization libraries to serialize this
object without any additional annotation, wrapping, injection etc.
Existing methods are now marked as deprecated. Tests have been
updated to test both code paths.
I've run the tests locally twice, with some failures both times. However, different tests failed each time, and they were in parts of the code that, to my reading, have no relation to the code being changed. I suspect they are just flakey tests.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mihasya commented on pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class
Posted by GitBox <gi...@apache.org>.
mihasya commented on pull request #10569:
URL: https://github.com/apache/kafka/pull/10569#issuecomment-823541177
@vvcephei Looks like you merged the original code. Hoping this is pretty easy, but let me know if I missed anything. Cheers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #10569: KAFKA-12696: Adds standardized getters to LagInfo class
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #10569:
URL: https://github.com/apache/kafka/pull/10569#issuecomment-823712852
This PR proposes a public API change and a KIP is required before it could be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org