[jira] Commented: (HADOOP-4235) [HOD] Accounting option should be displayed in hod help options

["Hemanth Yamijala (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633152#action_12633152 ] 

Hemanth Yamijala commented on HADOOP-4235:
------------------------------------------

The attached patch enhances hod help messages to include the accouting script information as an optional argument. This treats the accounting string as a special case, which is a short term solution. Longer term, we should have a way of printing optional arguments relevant to a command without making special cases.

The patch also changes how output from the verify-account script is returned. Specifically, it makes two changes:
- It prints the information and logs at a debug level. By printing, we make sure the output from the script is not prepended with an logger related strings like "CRITICAL" etc. The logging at debug level still ensures we print it to the log file also.
- It trims a trailing newline from the output.

hod help messages look like this now:

{code}
$ hod help allocate
Usage       : hod allocate -d <clusterdir> -n <nodecount> [-A account] [OPTIONS]
Description : Allocates a cluster of n nodes using the specified
              cluster directory to store cluster state
              information. The Hadoop site XML is also stored
              in this location.
              Depending on site policies, this operation may require
              a valid account string to be specified.
For all options : hod help options.
{code}

{code}
$ hod allocate
Usage       : hod allocate -d <clusterdir> -n <nodecount> [-A account] [OPTIONS]
For full description: hod help allocate.
{code}



> [HOD] Accounting option should be displayed in hod help options
> ---------------------------------------------------------------
>
>                 Key: HADOOP-4235
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4235
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/hod
>    Affects Versions: 0.18.1
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>         Attachments: HADOOP-4235.patch
>
>
> HADOOP-4145 enabled accounting checks to be plugged into HOD. With this, some sites may mandate the account string to be passed to HOD, via the -A or --resource_manager.pbs-account option. However, HOD allocate and script commands' help does not currently display this option. This issue is for enhancing the help messages for improved usability.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.