You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Deepak Jaiswal <dj...@hortonworks.com> on 2017/10/30 19:08:14 UTC

Review Request 63427: HIVE-17396

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63427/
-----------------------------------------------------------

Review request for hive and Jason Dere.


Repository: hive-git


Description
-------

Dynamic Semijoin Reduction : markSemiJoinForDPP marks unwanted semijoin branches

In method markSemiJoinForDPP (HIVE-17399), the nDVs comparison should not have equality as there is a chance that the values are same on both sides and the branch is still marked as good when it shouldn't be.
Add a configurable factor to see how useful this is if nDVs on smaller side are only slightly less than that on TS side.


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6631a6e45d 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java da30c3b642 
  ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q 6cc0a7f7a9 
  ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 1a1a4d9b2d 


Diff: https://reviews.apache.org/r/63427/diff/1/


Testing
-------


Thanks,

Deepak Jaiswal