You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Martin Furter <mf...@rola.ch> on 2004/12/21 23:50:53 UTC

[PATCH] svnmirror nothing to do case

Hello

Would a kind soul please commit this patch by John Belmonte ?

Thanks
Martin

<<<

Update to svnmirror.sh submitted by John Belmonte <jo...@neggie.net>.

* contrib/server-side/svnmirror.sh
    + print a non-error message to stdout instead of stderr.

>>>

Index: contrib/server-side/svnmirror.sh
===================================================================
--- contrib/server-side/svnmirror.sh    (revision 12487)
+++ contrib/server-side/svnmirror.sh    (working copy)
@@ -50,6 +50,8 @@
 #         - for some help with the svn commands
 #       - Bjørn Magnus Mathisen <ep...@generation.no>
 #         - for pointing out i forgot to replace one ssh with $LSSH
+#       - John Belmonte <jo...@neggie.net>
+#         - for pointing out that we use stderr for a non-error message
 #
 # Users:
 #    our biggest users atm are Mono Project and MonoDevelop
@@ -74,6 +76,8 @@
 #
 # Changes:
 #
+#  0.0.6
+#    + print a non-error message to stdout instead of stderr.
 #  0.0.5
 #    + added DUMPPARAMS to specify the params for the svnadmin dump call
 #    + added note about svnadmin 1.1 and "--deltas" cmdline option
@@ -330,7 +334,7 @@
 #
 if [ ${RVERSION} -eq ${LVERSION} ] ; then
     [ ${VERBOSE} = true ] && \
-        echo "both repositories are already at ${LVERSION}" >&2
+        echo "both repositories are already at ${LVERSION}"
     exit 0
 fi


On Tue, 21 Dec 2004, John Belmonte wrote:

> Hello,
> 
> Regarding svnmirror, if the repositories are in sync, I don't think 
> there should be a message on stderr.  This allows svnmirror to be used 
> from a cron job easily, where normal output is logged to a file, and 
> anything on stderr propagates to cron as an error.
> 
> If I should be submitting this patch elsewhere, please let me know.
> 
> Regards,
> -John
> 
> 
> 
> --- svnmirror~  2004-12-21 12:11:39.000000000 -0500
> +++ svnmirror   2004-12-21 13:39:59.000000000 -0500
> @@ -330,7 +330,7 @@
>   #
>   if [ ${RVERSION} -eq ${LVERSION} ] ; then
>       [ ${VERBOSE} = true ] && \
> -        echo "both repositories are already at ${LVERSION}" >&2
> +        echo "both repositories are already at ${LVERSION}"
>       exit 0
>   fi
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org


Re: [PATCH] svnmirror nothing to do case

Posted by Max Bowsher <ma...@ukf.net>.
Martin Furter wrote:
> Hello
> 
> Would a kind soul please commit this patch by John Belmonte ?
> 
> Thanks
> Martin
> 
> <<<
> 
> Update to svnmirror.sh submitted by John Belmonte <jo...@neggie.net>.
> 
> * contrib/server-side/svnmirror.sh
>     + print a non-error message to stdout instead of stderr.
> 
> >>> 

Done. In view of this:
...
>  # Changes:
>  #
> +#  0.0.6
> +#    + print a non-error message to stdout instead of stderr.
>  #  0.0.5
...

I also bumped the VERSION="x.y.z" line from 0.0.5 to 0.0.6

Max.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org