You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2021/11/29 11:38:19 UTC
[Bug 65711] New: XSLFSheet.importBlip overrides relation IDs
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
Bug ID: 65711
Summary: XSLFSheet.importBlip overrides relation IDs
Product: POI
Version: 5.0.x-dev
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: XSLF
Assignee: dev@poi.apache.org
Reporter: 0x00ten@gmail.com
Target Milestone: ---
Created attachment 38106
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38106&action=edit
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
The "importBlip" method of the "XSLFSheet" class creates relations with the
same IDs as the original blips causing possible collisions.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from PJ Fanning <fa...@yahoo.com> ---
thanks - but can you provide a unit test?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
Max <0x...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #38107|0 |1
is obsolete| |
Attachment #38108|0 |1
is obsolete| |
--- Comment #5 from Max <0x...@gmail.com> ---
Created attachment 38109
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38109&action=edit
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
Updated the patch with a test with a real presentation.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #38107|1 |0
is obsolete| |
--- Comment #4 from PJ Fanning <fa...@yahoo.com> ---
Comment on attachment 38107
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38107
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
importBlip is not a public method? Do you have a test case that reproduces your
issue that only uses public methods? It's possible that you are not using the
APIs like they were intended to be used.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
Roman Melnik <ro...@storied.co> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |roman.melnik@storied.co
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
--- Comment #6 from PJ Fanning <fa...@yahoo.com> ---
Comment on attachment 38109
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38109
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
this change seems to make this test fail -
TestXSLFBugs > bug62587() FAILED
org.opentest4j.AssertionFailedError at TestXSLFBugs.java:291
there could be more issues
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
--- Comment #8 from PJ Fanning <fa...@yahoo.com> ---
added test using r1895407
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
--- Comment #9 from PJ Fanning <fa...@yahoo.com> ---
added test using r1895407
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
Max <0x...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #38106|0 |1
is obsolete| |
--- Comment #2 from Max <0x...@gmail.com> ---
Created attachment 38107
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38107&action=edit
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
Hi. Sure, updated the patch.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
Max <0x...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #38107|0 |1
is obsolete| |
--- Comment #3 from Max <0x...@gmail.com> ---
Created attachment 38108
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38108&action=edit
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 65711] XSLFSheet.importBlip overrides relation IDs
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=65711
PJ Fanning <fa...@yahoo.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #38108|1 |0
is obsolete| |
--- Comment #7 from PJ Fanning <fa...@yahoo.com> ---
Comment on attachment 38108
--> https://bz.apache.org/bugzilla/attachment.cgi?id=38108
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
made a preliminary commit - r1895405 - will follow up and add extra tests if
this doesn't cause more problems
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org