[GitHub] guacamole-server pull request #182: GUACAMOLE-470: Support named colors in c...

[darchons <gi...@git.apache.org>]

GitHub user darchons opened a pull request:

    https://github.com/apache/guacamole-server/pull/182

    GUACAMOLE-470: Support named colors in color-scheme configuration.

    Named colors don't currently work inside the color-scheme configuration, because `guac_terminal_named_color_search` expects the name string to be null-terminated, whereas we work with non-null-terminated strings when parsing the color scheme.
    
    To make named colors work, we can either copy the name string to a separate null-terminated buffer, or we can make `guac_terminal_named_color_search` support non-null-terminated strings. This patch implements the latter option, and makes `guac_terminal_named_color_search` treat semi-colons as string terminators.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/darchons/guacamole-server guac-470-support-named-colors

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-server/pull/182.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #182
    
----
commit eb5aa14a6fac9b10201a48960bacdac274c251be
Author: Jim Chen <nc...@...>
Date:   2018-08-24T03:36:26Z

    GUACAMOLE-470: Support named colors in color-scheme configuration.
    
    When parsing named colors, treat semi-colons as string terminators, so
    we can properly parse named colors within the color-scheme
    configuration.

----


---

[GitHub] guacamole-server pull request #182: GUACAMOLE-470: Support named colors in c...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/guacamole-server/pull/182


---