You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Brock Noland (Created) (JIRA)" <ji...@apache.org> on 2012/02/10 18:55:00 UTC
[jira] [Created] (FLUME-960) TestAvroSink.testFailedConnect is racy
and fails often
TestAvroSink.testFailedConnect is racy and fails often
------------------------------------------------------
Key: FLUME-960
URL: https://issues.apache.org/jira/browse/FLUME-960
Project: Flume
Issue Type: Bug
Reporter: Brock Noland
Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-960) TestAvroSink.testFailedConnect is racy
and fails often
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-960:
-------------------------------
Attachment: FLUME-960.patch
Patch attached.
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Components: Test
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Attachments: FLUME-960.patch
>
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLUME-960) TestAvroSink.testFailedConnect is
racy and fails often
Posted by "Arvind Prabhakar (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar resolved FLUME-960.
------------------------------------
Resolution: Fixed
Fix Version/s: v1.1.0
Patch committed to flume-728 branch. Thanks Brock!
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Components: Test
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.1.0
>
> Attachments: FLUME-960.patch
>
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-960) TestAvroSink.testFailedConnect is
racy and fails often
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205634#comment-13205634 ]
jiraposter@reviews.apache.org commented on FLUME-960:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3837/
-----------------------------------------------------------
Review request for Flume.
Summary
-------
TestAvroSink fails often for two reasons:
1) We call close before the socket has started
2) We call sink.process before the socket has shutdown
This puts a small sleep into fix those two issues.
This addresses bug FLUME-960.
https://issues.apache.org/jira/browse/FLUME-960
Diffs
-----
flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java a46acc0
Diff: https://reviews.apache.org/r/3837/diff
Testing
-------
After the change, I ran the test 120 times and it passed 120 times.
Thanks,
Brock
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Reporter: Brock Noland
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-960) TestAvroSink.testFailedConnect is
racy and fails often
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206681#comment-13206681 ]
Hudson commented on FLUME-960:
------------------------------
Integrated in flume-728 #108 (See [https://builds.apache.org/job/flume-728/108/])
FLUME-960. TestAvroSink.testFailedConnect is racy and fails often.
(Brock Noland via Arvind Prabhakar) (Revision 1243412)
Result = FAILURE
arvind : http://svn.apache.org/viewvc/?view=rev&rev=1243412
Files :
* /incubator/flume/branches/flume-728/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Components: Test
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Fix For: v1.1.0
>
> Attachments: FLUME-960.patch
>
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FLUME-960) TestAvroSink.testFailedConnect is
racy and fails often
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206583#comment-13206583 ]
jiraposter@reviews.apache.org commented on FLUME-960:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3837/#review5036
-----------------------------------------------------------
Ship it!
+1. Please attach the patch to the jira.
- Arvind
On 2012-02-10 18:53:41, Brock Noland wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3837/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-10 18:53:41)
bq.
bq.
bq. Review request for Flume.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. TestAvroSink fails often for two reasons:
bq.
bq. 1) We call close before the socket has started
bq. 2) We call sink.process before the socket has shutdown
bq.
bq. This puts a small sleep into fix those two issues.
bq.
bq.
bq. This addresses bug FLUME-960.
bq. https://issues.apache.org/jira/browse/FLUME-960
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java a46acc0
bq.
bq. Diff: https://reviews.apache.org/r/3837/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. After the change, I ran the test 120 times and it passed 120 times.
bq.
bq.
bq. Thanks,
bq.
bq. Brock
bq.
bq.
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Components: Test
> Affects Versions: v1.0.0
> Reporter: Brock Noland
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FLUME-960) TestAvroSink.testFailedConnect is
racy and fails often
Posted by "Arvind Prabhakar (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arvind Prabhakar reassigned FLUME-960:
--------------------------------------
Assignee: Brock Noland
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Components: Test
> Affects Versions: v1.0.0
> Reporter: Brock Noland
> Assignee: Brock Noland
> Attachments: FLUME-960.patch
>
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FLUME-960) TestAvroSink.testFailedConnect is racy
and fails often
Posted by "Brock Noland (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland updated FLUME-960:
-------------------------------
Component/s: Test
Affects Version/s: v1.0.0
> TestAvroSink.testFailedConnect is racy and fails often
> ------------------------------------------------------
>
> Key: FLUME-960
> URL: https://issues.apache.org/jira/browse/FLUME-960
> Project: Flume
> Issue Type: Bug
> Components: Test
> Affects Versions: v1.0.0
> Reporter: Brock Noland
>
> Sometimes the close in TestAvroSink.testFailedConnect has not closed down before we get to the first sink.process as such sink.process fails.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira