You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/19 20:36:09 UTC

[GitHub] [nifi] ChrisSamo632 commented on pull request #6687: NIFI-10844 allow _source only output for GetElasticsearch and JsonQueryElasticsearch processors

ChrisSamo632 commented on PR #6687:
URL: https://github.com/apache/nifi/pull/6687#issuecomment-1358286729

   > Thanks for the contribution @ChrisSamo632, this looks like a useful improvement.
   > 
   > One implementation note, rather defining instances of `AllowableValue`, what do you think about creating two new `enum` definitions, named `SearchResultFormat` and `AggregationResultFormat`, both of which could implement `DescribedValue`. This approach supports using the `enum` name as the property value, and makes value handling and comparison a bit more straightforward.
   
   @exceptionfactory sounds sensible. I think `DescribedValue` is something (comparatively) new that I've not used before but have seen you/others mention in recent PRs - I'll look at how they're used and how to rework for this submission


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org