[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #7647: fix lookup editor to use lookup tiers instead of historical tiers

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #7647: fix lookup editor to use lookup tiers instead of historical tiers
URL: https://github.com/apache/incubator-druid/pull/7647#discussion_r283192703
 
 

 ##########
 File path: web-console/src/views/lookups-view.tsx
 ##########
 @@ -89,7 +89,7 @@ export class LookupsView extends React.Component<LookupsViewProps, LookupsViewSt
   componentDidMount(): void {
     this.lookupsGetQueryManager = new QueryManager({
       processQuery: async (query: string) => {
-        const tiersResp = await axios.get('/druid/coordinator/v1/tiers');
 
 Review comment:
   Will this always return at least a `__default` tier? That is needed for the dropdown to work nicely.
   If not it might make sense to add a UI side check for it...
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org