You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Rushabh S Shah (JIRA)" <ji...@apache.org> on 2017/06/29 18:22:00 UTC
[jira] [Comment Edited] (HADOOP-14599) RPC queue time metrics omit
timed out clients
[ https://issues.apache.org/jira/browse/HADOOP-14599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068738#comment-16068738 ]
Rushabh S Shah edited comment on HADOOP-14599 at 6/29/17 6:21 PM:
------------------------------------------------------------------
Thanks [~aramesh2] for working on this.
Seems like a good improvement to metrics.
Couple of comments.
1.
bq. + updateMetrics(methodName , (int)(Time.monotonicNow() - timestamp), 0, true);
The third parameter is {{processingTime}} and for rejected calls, the processing time _should not_ be 0.
This means the call was processed in 0 ms.
For rejected calls, it shouldn't update processing time.
2. In {{TestRPC.java}},
bq. +import java.util.*;
Please don't use wild card characters for imports.
was (Author: shahrs87):
Thanks [~aramesh2] for working on this.
Seems like a good improvement to metrics.
Couple of comments.
1.
bq. + updateMetrics(methodName , (int)(Time.monotonicNow() - timestamp), 0, true);
The third parameter is {{processingTime}} and for rejected calls, the processing time should not be 0.
This means the call was processed in 0 ms.
For rejected calls, it shouldn't update processing time.
2. In {{TestRPC.java}},
bq. +import java.util.*;
Please don't use wild card characters for imports.
> RPC queue time metrics omit timed out clients
> ---------------------------------------------
>
> Key: HADOOP-14599
> URL: https://issues.apache.org/jira/browse/HADOOP-14599
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics, rpc-server
> Affects Versions: 2.7.0
> Reporter: Ashwin Ramesh
> Assignee: Ashwin Ramesh
> Attachments: HADOOP-14599.001.patch
>
>
> RPC average queue time metrics will now update even if the client who made the call timed out while the call was in the call queue.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org