[GitHub] [pulsar] merlimat commented on a change in pull request #10682: Fix binary license check issues.

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #10682:
URL: https://github.com/apache/pulsar/pull/10682#discussion_r637561763



##########
File path: pulsar-client-admin/pom.xml
##########
@@ -56,6 +56,11 @@
       <artifactId>jersey-media-json-jackson</artifactId>
     </dependency>
 
+    <dependency>
+      <groupId>jakarta.activation</groupId>
+      <artifactId>jakarta.activation-api</artifactId>
+    </dependency>

Review comment:
       Same as above, not sure why we need to add it here

##########
File path: distribution/server/src/assemble/LICENSE.bin.txt
##########
@@ -559,22 +559,20 @@ CDDL-1.1 -- licenses/LICENSE-CDDL-1.1.txt
     - org.glassfish.hk2-osgi-resource-locator-1.0.3.jar
     - org.glassfish.hk2.external-aopalliance-repackaged-2.6.1.jar
  * Jersey
-    - org.glassfish.jersey.containers-jersey-container-servlet-2.31.jar
-    - org.glassfish.jersey.containers-jersey-container-servlet-core-2.31.jar
-    - org.glassfish.jersey.core-jersey-client-2.31.jar
-    - org.glassfish.jersey.core-jersey-common-2.31.jar
-    - org.glassfish.jersey.core-jersey-server-2.31.jar
-    - org.glassfish.jersey.ext-jersey-entity-filtering-2.31.jar
-    - org.glassfish.jersey.media-jersey-media-jaxb-2.31.jar
-    - org.glassfish.jersey.media-jersey-media-json-jackson-2.31.jar
-    - org.glassfish.jersey.media-jersey-media-multipart-2.31.jar
-    - org.glassfish.jersey.inject-jersey-hk2-2.31.jar
+    - org.glassfish.jersey.containers-jersey-container-servlet-2.34.jar

Review comment:
       The log title should probably be changed into "Updating to Jersey 2.34"

##########
File path: pulsar-broker/pom.xml
##########
@@ -230,6 +230,11 @@
       <artifactId>jersey-media-json-jackson</artifactId>
     </dependency>
 
+    <dependency>

Review comment:
       Why do we need to specify the dependency here? Pinning the version in the `dependencyManagement` section in top level pom should be enough, no?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org