You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "sodonnel (via GitHub)" <gi...@apache.org> on 2023/06/13 12:25:07 UTC

[GitHub] [ozone] sodonnel opened a new pull request, #4882: HDDS-8835. ReplicationManager: Fix metrics to work with new RM

sodonnel opened a new pull request, #4882:
URL: https://github.com/apache/ozone/pull/4882

   ## What changes were proposed in this pull request?
   This change is to tidy up the metrics in ReplicationManager metrics. Some of the legacy metrics are no longer valid in the new RM, and the naming was inconsistent between the old Ratis metrics and EC metrics.
   
   The new metrics after this change look like the following:
   
   ```
   "name" : "Hadoop:service=StorageContainerManager,name=ReplicationManagerMetrics",
       "modelerType" : "ReplicationManagerMetrics",
       "tag.Hostname" : "835ec174c7ef",
       "InflightReplication" : 0,
       "InflightDeletion" : 0,
       "InflightEcReplication" : 0,
       "InflightEcDeletion" : 2,
       "UnderReplicatedQueueSize" : 0,
       "OverReplicatedQueueSize" : 0,
       "OpenContainers" : 0,
       "ClosingContainers" : 0,
       "QuasiClosedContainers" : 0,
       "ClosedContainers" : 14,
       "DeletingContainers" : 1,
       "DeletedContainers" : 0,
       "RecoveringContainers" : 0,
       "UnderReplicatedContainers" : 0,
       "MisReplicatedContainers" : 0,
       "OverReplicatedContainers" : 0,
       "MissingContainers" : 0,
       "UnhealthyContainers" : 0,
       "EmptyContainers" : 0,
       "OpenUnhealthyContainers" : 0,
       "StuckQuasiClosedContainers" : 0,
       "ReplicationCmdsSentTotal" : 0,
       "ReplicasCreatedTotal" : 0,
       "ReplicaCreateTimeoutTotal" : 0,
       "DeletionCmdsSentTotal" : 0,
       "ReplicasDeletedTotal" : 0,
       "ReplicaDeleteTimeoutTotal" : 0,
       "EcReplicationCmdsSentTotal" : 0,
       "EcDeletionCmdsSentTotal" : 62,
       "EcReplicasCreatedTotal" : 5,
       "EcReplicasDeletedTotal" : 0,
       "EcReconstructionCmdsSentTotal" : 15,
       "EcReplicaCreateTimeoutTotal" : 10,
       "EcReplicasDeletedTotal" : 0,
       "EcReplicaDeleteTimeoutTotal" : 60,
       "EcReconstructionCmdsDeferredTotal" : 0,
       "DeleteContainerCmdsDeferredTotal" : 0,
       "ReplicateContainerCmdsDeferredTotal" : 0
   ```
   
   There are some quite large changes as a result of renaming some getting and setter methods after changing the metric names, but the change is split into separate commits to make it easier to review.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-8835
   
   ## How was this patch tested?
   
   Some tests were modified, but this was mostly validated manually to produce the results above, by create containers and stopping and starting some nodes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


[GitHub] [ozone] adoroszlai merged pull request #4882: HDDS-8835. ReplicationManager: Fix metrics to work with new RM

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #4882:
URL: https://github.com/apache/ozone/pull/4882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org